Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warns when package is pinned #999

Merged
merged 1 commit into from
Aug 23, 2015
Merged

Conversation

mrinaldi
Copy link
Contributor

This PR warns when a package is pinned to a specific version.

This is what it looks like:

Paket version 1.31.0.0
Updating Ninject.Extensions.Logging.Log4Net in D:\Projects\paket-test\paket.dependencies
Resolving packages:
 Ninject.Extensions.Logging.Log4Net is pinned to version 2.2.0.4
 - Ninject.Extensions.Logging.Log4Net 2.2.0.4
 Ninject.Extensions.Logging is pinned to version 2.2.0.4
 - Ninject.Extensions.Logging 2.2.0.4
 - Ninject 2.2.1.4
 - log4net 2.0.3
D:\Projects\paket-test\paket.lock is already up-to-date
2 seconds - ready.

This is the first PR I'm working on to better report why a package had a version chosen, aiming to close #786 and #946.

@mrinaldi mrinaldi force-pushed the warn_pinned_packages branch from 849701c to 493949f Compare August 19, 2015 20:13
@forki
Copy link
Member

forki commented Aug 20, 2015

very cool. will look at it on monday when I'm back at work.

forki added a commit that referenced this pull request Aug 23, 2015
@forki forki merged commit 48ad5c2 into fsprojects:master Aug 23, 2015
@forki
Copy link
Member

forki commented Aug 23, 2015

gimme

@forki
Copy link
Member

forki commented Aug 24, 2015

could please only warn if there is a new version available and we can't updte due to the lock? I think at the moment it's always reporting the pins, right?

@mrinaldi
Copy link
Contributor Author

It's always reporting the pin, indeed. I can warn only when a new version is available, however, to do that, I'll have to get the available versions for those packages, which will increase the resolve time.

Is that OK?

@mrinaldi mrinaldi deleted the warn_pinned_packages branch August 24, 2015 15:14
@forki
Copy link
Member

forki commented Aug 24, 2015

Yes that would be OK. I thought we already do this in the resolver. If so
you can reuse the cached information.
On Aug 24, 2015 5:13 PM, "Marcio Rinaldi" [email protected] wrote:

It's always reporting the pin, indeed. I can warn only when a new version
is available, however, to do that, I'll have to get the available versions
for those packages, which will increase the resolve time.

Is that OK?


Reply to this email directly or view it on GitHub
#999 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output WHY a package wasn't updated to the latest version
2 participants