Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github files (WIP #9) #93

Closed
wants to merge 3 commits into from

Conversation

isaacabraham
Copy link
Contributor

There are several changes here to bring in individual files from GitHub (#9). In this current version, it can parse a new type of entry, a "source file" in the .dependencies file which records github owner, project, file path and optionally a commit (branch, tag or rev); this is then pushed into the lockfile. When parsing the lockfile, the files are downloaded locally into a consistent file path relative to the lockfile.

Not included yet: -

  • Modifying the project file to include the file.
  • Looking at the reference file.
  • Removing files after they are removed from the dependencies file.
  • No thought currently given to updating a file that is tied to a named commit e.g. "master" when master moves on.

Please review.

@isaacabraham
Copy link
Contributor Author

"No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself."?

@agross
Copy link
Contributor

agross commented Sep 13, 2014

The build sometimes hangs. We don't know why yet.

Alex

Alexander Groß
Tiny phone, tiny mail

On Sat, Sep 13, 2014 at 10:38 PM, Isaac Abraham [email protected]
wrote:

"No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself."?

Reply to this email directly or view it on GitHub:
#93 (comment)

@isaacabraham
Copy link
Contributor Author

Can I force a re-build?


From: Alexander Großmailto:[email protected]
Sent: ‎13/‎09/‎2014 21:49
To: fsprojects/Paketmailto:[email protected]
Cc: Isaac Abrahammailto:[email protected]
Subject: Re: [Paket] Github files (WIP #9) (#93)

The build sometimes hangs. We don't know why yet.

Alex

Alexander Groß
Tiny phone, tiny mail

On Sat, Sep 13, 2014 at 10:38 PM, Isaac Abraham [email protected]
wrote:

"No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself."?

Reply to this email directly or view it on GitHub:
#93 (comment)


Reply to this email directly or view it on GitHub:
#93 (comment)

@agross
Copy link
Contributor

agross commented Sep 13, 2014

git commit --amend --no-edit
git push -f origin your-branch

Other than that, I don't know how to force a build.

Alex

Alexander Groß
Tiny phone, tiny mail

On Sun, Sep 14, 2014 at 12:43 AM, Isaac Abraham [email protected]
wrote:

Can I force a re-build?


From: Alexander Großmailto:[email protected]
Sent: ‎13/‎09/‎2014 21:49
To: fsprojects/Paketmailto:[email protected]
Cc: Isaac Abrahammailto:[email protected]
Subject: Re: [Paket] Github files (WIP #9) (#93)
The build sometimes hangs. We don't know why yet.

Alex

Alexander Groß
Tiny phone, tiny mail
On Sat, Sep 13, 2014 at 10:38 PM, Isaac Abraham [email protected]
wrote:

"No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself."?

Reply to this email directly or view it on GitHub:

#93 (comment)

Reply to this email directly or view it on GitHub:

#93 (comment)

Reply to this email directly or view it on GitHub:
#93 (comment)

@forki
Copy link
Member

forki commented Sep 14, 2014

Yes that's one easy way, but maybe I can give you more rights on TravisCI.
On Sep 14, 2014 1:09 AM, "Alexander Groß" [email protected] wrote:

git commit --amend --no-edit
git push -f origin your-branch

Other than that, I don't know how to force a build.

Alex

Alexander Groß
Tiny phone, tiny mail

On Sun, Sep 14, 2014 at 12:43 AM, Isaac Abraham [email protected]

wrote:

Can I force a re-build?


From: Alexander Großmailto:[email protected]
Sent: ‎13/‎09/‎2014 21:49
To: fsprojects/Paketmailto:[email protected]
Cc: Isaac Abrahammailto:[email protected]
Subject: Re: [Paket] Github files (WIP #9) (#93)
The build sometimes hangs. We don't know why yet.

Alex

Alexander Groß
Tiny phone, tiny mail
On Sat, Sep 13, 2014 at 10:38 PM, Isaac Abraham <
[email protected]>
wrote:

"No output has been received in the last 10 minutes, this potentially

indicates a stalled build or something wrong with the build itself."?

Reply to this email directly or view it on GitHub:

#93 (comment)

Reply to this email directly or view it on GitHub:

#93 (comment)

Reply to this email directly or view it on GitHub:
#93 (comment)


Reply to this email directly or view it on GitHub
#93 (comment).

@isaacabraham
Copy link
Contributor Author

@forki at any rate - i'm just interested whether the code so far is "ok" - is the format of the dependencies and lock file ok etc.?

@forki
Copy link
Member

forki commented Sep 14, 2014

I will have a look tomorrow.

@isaacabraham
Copy link
Contributor Author

ok cool.

@isaacabraham
Copy link
Contributor Author

Something's gone wrong with the rebase for this PR - closing and resubmitting.

@bartelink bartelink mentioned this pull request Sep 14, 2014
dcorriveau-omniscient added a commit to dcorriveau-omniscient/Paket that referenced this pull request Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants