Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hard path to bash #681

Merged
merged 1 commit into from
Mar 6, 2015
Merged

remove hard path to bash #681

merged 1 commit into from
Mar 6, 2015

Conversation

qbit
Copy link
Contributor

@qbit qbit commented Mar 5, 2015

On systems like OpenBSD bash is installed to /usr/local/bin/bash - this diff removes the hard coded /bin/bash in favor of pulling the path from the users environment.

@forki
Copy link
Member

forki commented Mar 5, 2015

@ilkerde @dnauck I'd love to hear an opinion from someone else. You know I'm noob in such things...

@ilkerde
Copy link
Contributor

ilkerde commented Mar 6, 2015

@qbit Thanks for fixing this. @forki Good stuff over here. It embraces crossplatform compatibility.

@dnauck
Copy link
Contributor

dnauck commented Mar 6, 2015

@forki this is a good change

forki added a commit that referenced this pull request Mar 6, 2015
remove hard path to bash
@forki forki merged commit b72876a into fsprojects:master Mar 6, 2015
@cdrnet
Copy link
Member

cdrnet commented Mar 6, 2015

@qbit could you also propose this upstream in ProjectScaffold? Thanks

@forki
Copy link
Member

forki commented Mar 6, 2015

Yes I was going to suggest this too.
On Mar 6, 2015 9:32 AM, "Christoph Ruegg" [email protected] wrote:

@qbit https://github.com/qbit could you also propose this upstream in
ProjectScaffold https://github.com/fsprojects/ProjectScaffold? Thanks


Reply to this email directly or view it on GitHub
#681 (comment).

@qbit
Copy link
Contributor Author

qbit commented Mar 6, 2015

@cdrnet @forki @ilkerde will do! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants