Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #670, inter project dependencies without matching package id #671

Merged
merged 2 commits into from
Mar 3, 2015

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Mar 3, 2015

Fix for #670

Use the project name (without extension) to uniquely identify projects when determining inter project dependencies.

For this I added a new property on the ProjectFile for getting the project name without extension, so I've also used this in a couple of other places from some previous work I did.

@ascjones ascjones changed the title Fix for https://github.com/fsprojects/Paket/issues/670 Fix for #670, inter project dependencies without matching package id Mar 3, 2015
forki added a commit that referenced this pull request Mar 3, 2015
Fix for #670, inter project dependencies without matching package id
@forki forki merged commit e53a23d into fsprojects:master Mar 3, 2015
@forki
Copy link
Member

forki commented Mar 3, 2015

thank you!

@mavnn
Copy link
Contributor

mavnn commented Mar 3, 2015

Thanks. Does it do what you want now?

@ascjones
Copy link
Contributor Author

ascjones commented Mar 3, 2015

Indeed it does, project references with corresponding paket.templates files are included as dependencies

@mavnn
Copy link
Contributor

mavnn commented Mar 3, 2015

Awesome :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants