-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove parsing of invalid child element of ProjectReference #453
Conversation
Fixes issue fsprojects#452. According to http://msdn.microsoft.com/en-us/library/bb629388.aspx the Private element in question is not a child element of ProjectReference item. (Also it was not used anywhere at all)
Any chance to get this merged in? |
Yes tomorrow I'm home again and can do it
|
👍 |
Ha. that's a nice fix ;-) |
Remove parsing of invalid child element of ProjectReference
;-) Kind of liked fixing an issue by removal of code only. |
yes if the backets would be on different lines it would be +0-2 - Kudos! |
released in 0.18.10 |
Is this |
Yes it's used in other projects. We should put it in a surface area...
|
@mexx I'm using it in this: fsprojects/ProjectScaffold#116 |
Fixes issue #452.
According to http://msdn.microsoft.com/en-us/library/bb629388.aspx the Private element in question is not
a child element of ProjectReference item.
(Also it was not used anywhere at all)