Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parsing of invalid child element of ProjectReference #453

Merged
merged 1 commit into from
Dec 17, 2014

Conversation

Vidarls
Copy link
Contributor

@Vidarls Vidarls commented Dec 12, 2014

Fixes issue #452.
According to http://msdn.microsoft.com/en-us/library/bb629388.aspx the Private element in question is not
a child element of ProjectReference item.
(Also it was not used anywhere at all)

Fixes issue fsprojects#452.
According to http://msdn.microsoft.com/en-us/library/bb629388.aspx the Private element in question is not
a child element of ProjectReference item.
(Also it was not used anywhere at all)
@Vidarls
Copy link
Contributor Author

Vidarls commented Dec 16, 2014

Any chance to get this merged in?

@forki
Copy link
Member

forki commented Dec 16, 2014

Yes tomorrow I'm home again and can do it
On Dec 16, 2014 1:04 PM, "Vidar Løvbrekke Sømme" [email protected]
wrote:

Any chance to get this merged in?


Reply to this email directly or view it on GitHub
#453 (comment).

@Vidarls
Copy link
Contributor Author

Vidarls commented Dec 16, 2014

👍

@forki
Copy link
Member

forki commented Dec 17, 2014

Ha. that's a nice fix ;-)

forki added a commit that referenced this pull request Dec 17, 2014
Remove parsing of invalid child element of ProjectReference
@forki forki merged commit a86983c into fsprojects:master Dec 17, 2014
@Vidarls
Copy link
Contributor Author

Vidarls commented Dec 17, 2014

;-) Kind of liked fixing an issue by removal of code only.

@forki
Copy link
Member

forki commented Dec 17, 2014

yes if the backets would be on different lines it would be +0-2 - Kudos!

@forki
Copy link
Member

forki commented Dec 17, 2014

released in 0.18.10

@mexx
Copy link
Member

mexx commented Dec 17, 2014

Is this ProjectReference type ever used in productive code? I can't find any usage besides of unit tests.

@forki
Copy link
Member

forki commented Dec 17, 2014

Yes it's used in other projects. We should put it in a surface area...
On Dec 17, 2014 8:20 PM, "Max Malook" [email protected] wrote:

Is this ProjectReference type ever used in productive code? I can't find
any usage besides of unit tests.


Reply to this email directly or view it on GitHub
#453 (comment).

@Vidarls
Copy link
Contributor Author

Vidarls commented Dec 17, 2014

@mexx I'm using it in this: fsprojects/ProjectScaffold#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants