Referencing of multiple files from same repository directory #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
added a commit
that referenced
this pull request
Dec 9, 2014
Referencing of multiple files from same repository directory
|
|
||
| if isInRightVersion then | ||
| verbosefn "Sourcefile %s is already there." (source.ToString()) | ||
| else | ||
| tracefn "Downloading %s to %s" (source.ToString()) destination | ||
|
|
||
| CleanDir (destination |> Path.GetDirectoryName) | ||
| destination |> Path.GetDirectoryName |> CleanDir |
There was a problem hiding this comment.
It doesn't work as CleanDir removes the directory with all the already downloaded files.
There was a problem hiding this comment.
ahj this would explain #442
There was a problem hiding this comment.
Better, but if someone reference multiple files from different branches, so version would differ and the behavior is not predictable and we would still get access errors.
There was a problem hiding this comment.
Yes. That's true I don't have a good solution right now. Maybe you see a better way
There was a problem hiding this comment.
Provided better handling with #451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should allow to unbundle FSharp.Data from Deedle
/cc @tpetricek, @isaacabraham, @mexx