Http links #428
Merged
Http links #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow @forki !!! You are so fast... |
|
is that a "ship it"? |
|
Yes, it is faster now and download files only once, but it makes very strange calls to the server. |
|
that's actually expected. It tries to locate a (in this case not existing) paket.dependencies file. This allows you to specify further dependencies. see http://fsprojects.github.io/Paket/github-dependencies.html#Remote-dependencies |
|
It is a bit strange for me... I thought about something like caching calls during the paket process lifetime... But if it is an expected behavior... no other complaints - "ship it"! |
|
released in 0.17.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL of the dependencies file for HTTP links is wrong see https://github.com/fsprojects/Paket/compare/HTTPLinks?expand=1#diff-f49621e896c9b89745f9d4aa9e06cb6fR48
The result is that we currently download the HTTP resource twice. This makes things very slow - as seen in #298
/cc @sergey-tihon