Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate BindingRedirects into Paket install process. #383

Merged
merged 1 commit into from
Nov 23, 2014

Conversation

isaacabraham
Copy link
Contributor

This PR integrates the code for #245 into the main install process. There are a few fixes I made at the same time.

Issues: -

  • Does not support removal of BRs when a dependency is removed.
  • Is greedy i.e. will simply put a BR for every strong-named assembly even if not necessarily required.

Could use some feedback on this as to where it should go from here (and whether I've integrated it in the correct place).

Correct some issues with BindingRedirects e.g. namespaces and neutral culture.
@forki
Copy link
Member

forki commented Nov 23, 2014

how can I test this?

forki added a commit that referenced this pull request Nov 23, 2014
Integrate BindingRedirects into Paket install process.
@forki forki merged commit 5382721 into fsprojects:master Nov 23, 2014
@isaacabraham
Copy link
Contributor Author

Just run a Paket install and check the .config files afterwards. There are unit tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants