Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress: Improved support for NuGet packages with multiple targets #381

Closed

Conversation

christianlang
Copy link
Contributor

This PR is trying to implement the changes explained in #380 into Paket.

@christianlang
Copy link
Contributor Author

@forki I had just rebased, but your change from 5 minutes ago created another conflict.

@forki
Copy link
Member

forki commented Nov 22, 2014

soorry. but that's what I meant. It's moving fast so we always create merge conflicts ;-)

@christianlang
Copy link
Contributor Author

I know :) no problem. I'll rebase again.

Until now it creates both, lib folders and framework groups. Removing groups will be the next step.
@forki
Copy link
Member

forki commented Nov 22, 2014

very cool. I will try to work on something else for the meantime.

@christianlang
Copy link
Contributor Author

@forki it sort-of works now. I can run Paket and it will add references to my project files using the new logic. I'm sure it has bugs and I have 19 failing unit tests. But I'm off for today (and for the weekend probably). Feel free to continue with this. I'm going to ping you when I continue working on it (Monday, I guess).

@forki forki closed this Nov 22, 2014
@forki
Copy link
Member

forki commented Nov 22, 2014

Very cool. I created #382 in order to keep track of the progress.
I already fixed a couple of unittests.
The generated XML still looks not correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants