Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt PackTask to breaking changes in MsBUild 16 - missing condition #3543

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

cdrnet
Copy link
Member

@cdrnet cdrnet commented Apr 8, 2019

Unfortunately somehow a condition got lost while preparing the PR #3542. This is needed to properly fix #3540

Without this line, in cases where MsBuild 16 is detected, it actually gets handled by NuGet4.
Sorry!

Somehow the condition got lost while preparing the PR.
@cdrnet
Copy link
Member Author

cdrnet commented Apr 8, 2019

//cc @forki

@forki
Copy link
Member

forki commented Apr 8, 2019

thanks for quick fix!

@forki forki merged commit 527a900 into fsprojects:master Apr 8, 2019
@cdrnet cdrnet deleted the adapt-pack-to-msbuild16-addendum branch April 8, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running dotnet pack with Paket.Restore.Targets referenced in a new csproj file with msbuild 16 fails.
2 participants