Fix for #3494 #3534
Merged
Fix for #3494 #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
Update from fsprojects/master.
|
Sorry, but I don't use git very often. I tried to clean up the pull request with a rebase, but it looks like it just made more commits. The diff still looks correct, however. Feel free to instruct me to cleanup if necessary. |
|
This should be ready for review. It looks like only the flaky tests are failing. |
|
can you please merge with master? |
|
@forki Done. |
|
cool. do we need to add something to the docs? |
|
I don't believe so. Nothing public-facing changed and IMO it works as one would expect now when multi-targeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3494 by adding support for multiple target frameworks to the pack command.