Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Standard 2.1 support #3530

Merged
merged 29 commits into from
Apr 2, 2019
Merged

Add .NET Standard 2.1 support #3530

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
470f66a
Add .NET Standard 2.1 support
forki Mar 25, 2019
8648231
Remove DNXCore monikers and add .NET 4.8
forki Mar 25, 2019
655707d
remove that .NET 4.8 -> .NET Standard 2.1 arrow
forki Mar 25, 2019
a71ea67
Make test project compilable
forki Mar 25, 2019
742f550
Add the .NET 4.8 cases
forki Mar 25, 2019
7809c64
Handle .NET Standard 2.1 cases
forki Mar 25, 2019
e7be471
remove flaky test
forki Mar 25, 2019
ed038bc
Remove flaky tests
forki Mar 25, 2019
f5689e0
Remove flaky test
forki Mar 25, 2019
0a23d45
Remove flaky test
forki Mar 25, 2019
216015f
fix build
forki Mar 25, 2019
8b4fbca
Remove flaky tests
forki Mar 26, 2019
dc84446
Allow to parse DNX
forki Mar 26, 2019
377994b
Revert "remove flaky test"
forki Mar 26, 2019
7b939eb
DotNetCore is not PCL
forki Mar 26, 2019
f66564a
Remove flaky test
forki Mar 26, 2019
5e57ef4
Remove flaky test
forki Mar 26, 2019
3bbcb3f
Remove super slow test
forki Mar 26, 2019
38918f0
Test no longer needed
forki Mar 26, 2019
52b21d6
Tests no longer needed
forki Mar 26, 2019
b68a351
remove flaky test
forki Mar 26, 2019
9c9b032
Fody is missing
forki Mar 27, 2019
3635394
Ignore if a symlink is already there
forki Mar 27, 2019
65c0703
fix test on mono
forki Mar 28, 2019
2e35f92
remove flaky test
forki Mar 28, 2019
edfd7a4
Remove flaky tests
forki Mar 28, 2019
3079ff4
Test does not work on linux
forki Apr 1, 2019
0ef5d93
Remove flaky test
forki Apr 1, 2019
b58d5cd
Run on newer travis
forki Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions integrationtests/Paket.IntegrationTests/ResolverSkipsConflictsFastSpecs.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,24 +38,6 @@ let ``#2289 Paket 4.x install command takes hours to complete``() =
nunitVersion
|> shouldBeSmallerThan (SemVer.Parse "3.0")

[<Test; Flaky>]
let ``#2294 Cannot pin NETStandard.Library = 1.6.0``() =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like both of these are good tests, we should somehow keep them or set them to ignore.
In fact I think if they fail this indicates a regression in the resolver unable to find a solution in the specified test-timeout.
So what looked like "flaky" might just be a perf regression here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, yes resolving this might have become harder with the release of new packages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it was a regression - we fixed a resolver bug and it that made it slower. shit happens

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we fixed a resolver bug and it that made it slower

Isn't that the definition of a perf regression ;)
Anyway I think getting the CI green again is more important than these tests, so fine by me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. it never was faster - it was just wrong

let lockFile = update "i002294-pin-netstd16"
lockFile.Groups.[Constants.MainDependencyGroup].Resolution.[PackageName "NETStandard.Library"].Version
|> shouldEqual (SemVer.Parse "1.6")

//lots of downloaded files => big disk size, better cleanup if test pass
System.IO.Directory.Delete(scenarioTempPath "i002294-pin-netstd16", true)

[<Test; Flaky>]
let ``#2294 pin NETStandard.Library = 1.6.0 Strategy Workaround``() =
let lockFile = update "i002294-withstrategy"
lockFile.Groups.[Constants.MainDependencyGroup].Resolution.[PackageName "NETStandard.Library"].Version
|> shouldEqual (SemVer.Parse "1.6")

//lots of downloaded files => big disk size, better cleanup if test pass
System.IO.Directory.Delete(scenarioTempPath "i002294-withstrategy", true)

[<Test>]
let ``#2922 paket can jump out of loop of doom``() =
try
Expand Down
23 changes: 0 additions & 23 deletions integrationtests/scenarios/i002294-pin-netstd16/before/paket.dependencies
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions integrationtests/scenarios/i002294-withstrategy/before/paket.dependencies
View file
Open in desktop

This file was deleted.