-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .NET Standard 2.1 support #3530
Changes from 17 commits
470f66a
8648231
655707d
a71ea67
742f550
7809c64
e7be471
ed038bc
f5689e0
0a23d45
216015f
8b4fbca
dc84446
377994b
7b939eb
f66564a
5e57ef4
3bbcb3f
38918f0
52b21d6
b68a351
9c9b032
3635394
65c0703
2e35f92
edfd7a4
3079ff4
0ef5d93
b58d5cd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -354,21 +354,6 @@ let ``#1458 should not install conflicting deps from different groups``() = | |
with | ||
| exn when exn.Message.Contains "Package Nancy is referenced in different versions" -> () | ||
|
||
[<Test;Flaky>] | ||
let ``#2335 should install deps from different groups when using conditions``() = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is also a very interesting scenario we probably don't have covered in another test |
||
let scenario = "i002335-razorengine" | ||
install scenario |> ignore | ||
let newFile = Path.Combine(scenarioTempPath scenario,"MyClassLibrary","MyClassLibrary","MyClassLibrary.csproj") | ||
let oldFile = Path.Combine(originalScenarioPath scenario,"MyClassLibrary","MyClassLibrary","MyClassLibrary.csprojtemplate") | ||
if updateBaselines then | ||
File.Copy (newFile, oldFile, overwrite=true) | ||
let s1 = File.ReadAllText oldFile |> normalizeLineEndings | ||
let s2 = File.ReadAllText newFile |> normalizeLineEndings | ||
s2 |> shouldEqual s1 | ||
|
||
//lots of downloaded files => big disk size, better cleanup if test pass | ||
System.IO.Directory.Delete(scenarioTempPath scenario, true) | ||
|
||
[<Test>] | ||
let ``#1442 should not warn on SonarLint``() = | ||
let result = paket "install" "i001442-dont-warn" | ||
|
@@ -463,17 +448,6 @@ let ``#1746 hard should be softer``() = | |
let s2 = File.ReadAllText newFile |> normalizeLineEndings | ||
s2 |> shouldEqual s1 | ||
|
||
[<Test>] | ||
let ``#1333 should install framework refs only once``() = | ||
install "i001333-dup-refs" |> ignore | ||
let newFile = Path.Combine(scenarioTempPath "i001333-dup-refs","ConsoleApplication1","ConsoleApplication1.fsproj") | ||
let oldFile = Path.Combine(originalScenarioPath "i001333-dup-refs","ConsoleApplication1","ConsoleApplication1.fsprojtemplate") | ||
if updateBaselines then | ||
File.Copy (newFile, oldFile, overwrite=true) | ||
let s1 = File.ReadAllText oldFile |> normalizeLineEndings | ||
let s2 = File.ReadAllText newFile |> normalizeLineEndings | ||
s2 |> shouldEqual s1 | ||
|
||
[<Test>] | ||
let ``#1779 net20 only in net461``() = | ||
install "i001779-net20-only-in-net461" |> ignore | ||
|
@@ -518,13 +492,6 @@ let ``#3062 install should use external lock file``() = | |
newLockFile.Groups.[GroupName "main"].Resolution.ContainsKey (PackageName "FAKE") |> shouldEqual true | ||
newLockFile.Groups.[GroupName "main"].Resolution.[PackageName "Machine.Specifications"].Version |> shouldEqual (SemVer.Parse "0.12") | ||
|
||
[<Test;Flaky>] | ||
let ``#3062 install should use external azure functions v1 lock file from http``() = | ||
let newLockFile = install "i003062-azurefunctions" | ||
newLockFile.Groups.[GroupName "main"].Resolution.ContainsKey (PackageName "FAKE") |> shouldEqual true | ||
newLockFile.Groups.[GroupName "main"].Resolution.[PackageName "Newtonsoft.Json"].Version |> shouldEqual (SemVer.Parse "9.0.1") | ||
newLockFile.Groups.[GroupName "main"].Resolution.[PackageName "Microsoft.Azure.WebJobs.Core"].Version |> shouldEqual (SemVer.Parse "2.2.0") | ||
|
||
|
||
#if INTERACTIVE | ||
;; | ||
|
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,24 +38,6 @@ let ``#2289 Paket 4.x install command takes hours to complete``() = | |
nunitVersion | ||
|> shouldBeSmallerThan (SemVer.Parse "3.0") | ||
|
||
[<Test; Flaky>] | ||
let ``#2294 Cannot pin NETStandard.Library = 1.6.0``() = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like both of these are good tests, we should somehow keep them or set them to ignore. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On the other hand, yes resolving this might have become harder with the release of new packages. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think it was a regression - we fixed a resolver bug and it that made it slower. shit happens There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Isn't that the definition of a perf regression ;) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no. it never was faster - it was just wrong |
||
let lockFile = update "i002294-pin-netstd16" | ||
lockFile.Groups.[Constants.MainDependencyGroup].Resolution.[PackageName "NETStandard.Library"].Version | ||
|> shouldEqual (SemVer.Parse "1.6") | ||
|
||
//lots of downloaded files => big disk size, better cleanup if test pass | ||
System.IO.Directory.Delete(scenarioTempPath "i002294-pin-netstd16", true) | ||
|
||
[<Test; Flaky>] | ||
let ``#2294 pin NETStandard.Library = 1.6.0 Strategy Workaround``() = | ||
let lockFile = update "i002294-withstrategy" | ||
lockFile.Groups.[Constants.MainDependencyGroup].Resolution.[PackageName "NETStandard.Library"].Version | ||
|> shouldEqual (SemVer.Parse "1.6") | ||
|
||
//lots of downloaded files => big disk size, better cleanup if test pass | ||
System.IO.Directory.Delete(scenarioTempPath "i002294-withstrategy", true) | ||
|
||
[<Test>] | ||
let ``#2922 paket can jump out of loop of doom``() = | ||
try | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still fail and we should still report a good error message, correct?