Allow addition of <EmbedInteropTypes> for Nuget packages #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
You are welcome. Thanks for taking care of the failing tests. |
ruhullahshah
deleted the
support_embed_interop_types_flag_for_nuget_references
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
NuGet package reference with a COM interop DLL,
<EmbedInteropTypes>True</EmbedInteropTypes>needs to be managed manually andpaket updateremoves the flag.Solution
Provide a way to express this through existing
paket.referencessyntaxPkgName embed_interop_types: trueRelated Issues
paket install (+update?) should not overwrite EmbedInteropTypes flag #910
There might be some failing testcases but adding the PR to open up the discussion.