-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paket template packagetypes #3212
Paket template packagetypes #3212
Conversation
@@ -163,6 +163,8 @@ LANGUAGE | |||
en-gb | |||
tags | |||
rop, fsharp F# | |||
packageTypes | |||
DotnetTool, Template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to normalize user input somehow here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, i think is better to leave these as is, as normal string list.
nuspec doesnt show an enumeratin of values, is just like a tag
about the package type.
Nuget team may have choosen to just use some tag
, but instead is another property :( more complexity, few gains
also like that is less maintenance when new types are added. is really a small use case ihmo (template, clitool, dotnetool). and last two is better to be create with dotnet restore
probably
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'm fine with that (was basically just asking what you think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i was thinking about it too, good question.
And to validate it too (to output the right word with the same case as nuget, to play safe).
but use case is really small
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me
add
packageTypes
topaket.template
used by newer nuspec schema for types like
Template
,DotnetTool
,DotnetCliTool
is optional, and default is not set