Fix for #2573 #3120
Merged
Fix for #2573 #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding AutoGenerateBindingRedirects automatically when BindingRedirects are added to a config file
|
This is the suggested approach to take to get around the MSBuild warnings thrown by FSharp.Core in some situations when using MSBuild 15.6 if you don't target the latest FSharp.Core nuget package. See: dotnet/fsharp#4517 |
|
First is usually to go green ;) |
|
Error is unrelated
Matthias Dittrich <[email protected]> schrieb am Fr., 16. März 2018,
10:07:
… First is usually to go green ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3120 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNLF8uBOxrqPgRU6XmCmcM1OnWyHXks5te4DUgaJpZM4Sr4F1>
.
|
forki
reviewed
Mar 16, 2018
| |> List.iter(fun x -> x.InnerText <- "true") | ||
| else | ||
| let propertyGroups = project.Document |> getDescendants "PropertyGroup" | ||
| if propertyGroups.IsEmpty |> not then |
There was a problem hiding this comment.
please change to pattern matching
match propertyGroups with | x :: _ -> x.AppendChild (createNodeSet "AutoGenerateBindingRedirects" "true" project) |> ignore | _ -> ()
forki
reviewed
Mar 16, 2018
| @@ -1671,6 +1671,22 @@ module ProjectFile = | |||
| Kind = NugetPackageKind.DotnetCliTool | |||
| TargetFramework = None }) | |||
|
|
|||
| let getAutoGenerateBindingRedirects (project:ProjectFile) = getProperty "AutoGenerateBindingRedirects" project | |||
| let setOrCreateAutoGenerateBindingRedirects (project:ProjectFile) = | |||
| if (getAutoGenerateBindingRedirects project).IsSome then | |||
There was a problem hiding this comment.
same here please use pattern matching instead of if + isSome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2573 by adding AutoGenerateBindingRedirects automatically when BindingRedirects are added to a config file.
This change is documented here: https://docs.microsoft.com/en-us/dotnet/framework/configure-apps/how-to-enable-and-disable-automatic-binding-redirection
By enabling the setting it prevents MSBuild trying to do a unification.