Move to a more recent version of argu #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthid
approved these changes
Mar 12, 2018
| @@ -23,7 +23,7 @@ nuget NUnit.Console | |||
| nuget NUnit3TestAdapter version_in_path: true | |||
| clitool dotnet-mergenupkg | |||
|
|
|||
| github fsharp/FAKE src/app/FakeLib/Globbing/Globbing.fs | |||
| github fsharp/FAKE:0341a2e614eb2a7f34607cec914eb0ed83ce9add src/app/FakeLib/Globbing/Globbing.fs | |||
There was a problem hiding this comment.
The file moved to /src/legacy/FakeLib/Globbing/Globbing.fs that was probably the problem?
| @@ -700,7 +700,7 @@ with | |||
| | Version -> "show Paket version" | |||
| | From_Bootstrapper -> "call coming from the '--run' feature of the bootstrapper" | |||
|
|
|||
| let commandParser = ArgumentParser.Create<Command>(programName = "paket", errorHandler = new ProcessExiter()) | |||
| let commandParser = ArgumentParser.Create<Command>(programName = "paket", errorHandler = new ProcessExiter(), checkStructure = false) | |||
There was a problem hiding this comment.
Just out of curiosity what is the impact of this? Is there an impact?
There was a problem hiding this comment.
On performance it's faster :)
It also doesn't check the argument DU for incoherences, but it's forced in unit tests so it would fail there.
|
Thanks |
|
released in 5.150.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a few perf optimizations, waiting for the next ones