Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub sources in PublicAPI and CLI #3023

Merged
merged 15 commits into from
Mar 1, 2018
Merged

Add GitHub sources in PublicAPI and CLI #3023

merged 15 commits into from
Mar 1, 2018

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Feb 1, 2018

work in progress for implementing Git, GitHub, Gist and Http sources in CLI tool and PublicAPI

@frelon frelon mentioned this pull request Feb 1, 2018
Open
4 tasks
@enricosada
Copy link
Collaborator

about cli, @forki @matthid what do you think?

paket git add .. // and list remove etc
paket github add ..
paket http add ..

like git remote?

add lot of cmd add-git remove-git etc is annoying

Asking because i'd like something like that for repotool too

@frelon
Copy link
Contributor Author

frelon commented Feb 21, 2018

@enricosada I changed the cli and added the functions in AddProcess etc. Now you can run

paket github add fsprojects/paket

and it generates the paket.dependencies and paket.lock file correctly. It also supports the version, file and group parameters.

@forki
Copy link
Member

forki commented Feb 21, 2018

so no longer WIP?
@matthid @enricosada can you please review?

@frelon
Copy link
Contributor Author

frelon commented Feb 21, 2018

I could clean up the empty functions AddHttp, AddGit etc if you want to merge only the Github-functionality.
Then it's no longer WIP, no.

@frelon frelon changed the title [WIP] Sources in PublicAPI and CLI Sources in PublicAPI and CLI Feb 22, 2018
@forki forki requested a review from enricosada February 26, 2018 11:15
@frelon frelon changed the title Sources in PublicAPI and CLI Add GitHub sources in PublicAPI and CLI Feb 28, 2018
@forki
Copy link
Member

forki commented Mar 1, 2018

thanks!

@forki forki merged commit 533d36e into fsprojects:master Mar 1, 2018
@frelon frelon deleted the sources-in-publicapi branch March 1, 2018 19:46
agross
agross reviewed Mar 3, 2018
View reviewed changes
src/Paket/Commands.fs
@@ -625,6 +647,7 @@ with
member this.Usage =
match this with
| Add _ -> "add a new dependency"
| Github _ -> "commands to manipulate gihub repository references"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change gihub to GitHub?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! Opened #3100 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agross agross agross left review comments

@enricosada enricosada Awaiting requested review from enricosada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frelon @enricosada @forki @agross