-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3012 #3013
Fixes #3012 #3013
Conversation
…t defined in csproj file Get TargetFramework(s) from runtime as a fallback in case they are not defined in csproj file directory.build.props .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok (i need to test it locally later)
@msatina awesome work, can you add an integration test?
like
Paket/integrationtests/Paket.IntegrationTests/RestoreSpecs.fs
Lines 87 to 99 in 680bc18
[<Test>] | |
let ``#3000-a dotnet restore``() = | |
let scenario = "i003000-netcoreapp2" | |
let projectName = "c1" | |
let packageName = "AutoMapper" | |
let workingDir = scenarioTempPath scenario | |
let projectDir = workingDir @@ projectName | |
[ packageName; (packageName.ToLower()) ] |> Seq.iter clearPackage | |
prepareSdk scenario | |
directDotnet false "restore" projectDir |> ignore | |
directDotnet false "build --no-restore" projectDir |> ignore |
TargetFramework
in csproj, but in Directory.Build.props
as a note, VS need to fix this scenario probably #2863 (comment) |
<!-- Do a global restore if required --> | ||
<Exec Command='$(PaketBootStrapperCommand)' Condition="Exists('$(PaketBootStrapperExePath)') AND !(Exists('$(PaketExePath)'))" ContinueOnError="false" /> | ||
<Exec Command='$(PaketCommand) restore' Condition=" '$(PaketRestoreRequired)' == 'true' " ContinueOnError="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that calling paket restore
is by design here. We tweaked paket restore
for maximum performance (including skipped command line parsing). With this change restore will most likely be a lot slower if stuff was already restored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I'm trying to say is that we either need a different solution / carefully tweak performance for this case or some other trick
ping |
@matthid @enricosada better? |
thanks! |
fix #3012
Get TargetFramework(s) from runtime as a fallback in case they are not defined in csproj file.