Fixes a few things when framework: lines are parsed in template #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Accept the framework:foo format (without a space after ":") * Fail on unknown frameworks instead of silently ignoring
|
👍 ci error is unrelated |
|
Technically I think this is a breaking change, let’s see what happens... |
|
silent was bad => bug. be less strict on input file (hand edited by user) is not too bad. |
|
I consider it more of a bug fix even if there are some edge cases that it could break (Invalid file and the user never noticed and started to depend on invalid framework being merged with no-framework blocks) |
|
I was just saying, I think we reverted a similar change before. Don’t get me wrong I like the change ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to hunt some oddities due to that today 😉
framework:fooformat (without a space after ":")Note: I choose to fail hard using failwith instead of wiring the
Choice<,>around as dependency parsing ingetDependencyByLinealready does that.