Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove possibly nonexistent extension safely #2901

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Remove possibly nonexistent extension safely #2901

merged 1 commit into from
Dec 11, 2017

Conversation

domdom
Copy link
Contributor

@domdom domdom commented Nov 16, 2017

Fixes #2900

@domdom
Copy link
Contributor Author

domdom commented Nov 16, 2017 •
edited
Loading

I think there is actually a better solution, which is to use the Path.GetFileNameWithoutExtension method which seems to suit the use case perfectly. I can also replace other occurrences of this in the code base.

Pending feedback.

@forki
Copy link
Member

forki commented Dec 11, 2017

thanks!

@forki forki merged commit cda98c3 into fsprojects:master Dec 11, 2017
@domdom
Copy link
Contributor Author

domdom commented Dec 11, 2017

I'm happy to help, thanks for the work on paket :)

@domdom domdom deleted the patch-2 branch December 13, 2017 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domdom @forki