Adding feature to verify the URL and credential correctness before storing them in paket.config #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oring them in paket.config
forki
reviewed
Sep 20, 2017
src/Paket.Core/PublicAPI.fs
Outdated
| @@ -165,10 +165,10 @@ type Dependencies(dependenciesFileName: string) = | |||
| projectName, installAfter, runResolver)) | |||
|
|
|||
| /// Adds credentials for a Nuget feed | |||
| member this.AddCredentials(source: string, username: string, password : string, authType : string) : unit = | |||
| member this.AddCredentials(source: string, username: string, password : string, authType : string, verify : bool) : unit = | |||
There was a problem hiding this comment.
this one is in the PublicAPI and would be breaking.
We need a second function and keep the old one
forki
reviewed
Sep 20, 2017
|
|
||
| let authResult = | ||
| if verify then | ||
| Console.WriteLine "Verifying the source URL and credentials..." |
forki
requested changes
Sep 20, 2017
|
Thanks. I will update the code with the requested changes. |
forki
approved these changes
Sep 21, 2017
|
thx! |
|
You are welcome and thanks for the quick review, subsequent merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding a source and its credentials to paket.config, it often happens that there are typos or the credentials do not authenticate, in that case adding these credentials and sources to paket.config becomes pointless. So we propose to have --verify option to augment the config command. It verifies the URL for the source and the credentials are correct.