Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup PublicAPI #2643

Merged
merged 2 commits into from
Aug 21, 2017
Merged

Cleanup PublicAPI #2643

merged 2 commits into from
Aug 21, 2017

Conversation

forki
Copy link
Member

@forki forki commented Aug 21, 2017

No description provided.

@matthid
Copy link
Member

matthid commented Aug 21, 2017

I think this conflicts with #2638 on some lines

@forki
Copy link
Member Author

forki commented Aug 21, 2017

haha so I are telling me to merge it asap so that I'm clear? ;)

@forki
Copy link
Member Author

forki commented Aug 21, 2017

ok. I will keep it open until the other one is done.

@matthid
Copy link
Member

matthid commented Aug 21, 2017 •
edited
Loading

For example ;).
No idea, tbh ideal timeslot for cleanup is after big changes finished, but tbf that is never the case.

Nono please merge if ready I can live with the consequences :P

@forki forki merged commit 73664a7 into master Aug 21, 2017
@matthid matthid deleted the cleanpublic branch July 2, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forki @matthid