[Really Ready] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core #2528

0x53A · 2017-07-15T22:00:51Z

disable implicitly adding system.valuetuple and fsharp.core
fail when a sdk f# project does not contain a reference to fsharp.core

context: dotnet/fsharp#3335 (comment)

forki · 2017-07-16T07:55:58Z

fail when a sdk f# project does not contain a reference to fsharp.core

I don't think we need to do that. This is basically a thing that will happen later in build. We should not have this in paket.exe itself.

0x53A · 2017-07-16T08:38:09Z

I don't think we need to do that. This is basically a thing that will happen later in build. We should not have this in paket.exe itself

Thats the big issue - if you dont' pass any FSharp.Core to the compiler, it will silently pick any random one.

forki · 2017-07-16T08:54:16Z

if you dont' pass any FSharp.Core to the compiler, it will silently pick any random one

how? I think the targets file changes forbid that!?

0x53A · 2017-07-16T09:40:44Z

Please test it, maybe i missed something, but afaik it does not error out.

forki · 2017-07-16T09:42:52Z

If you have a repro? Can you please report that to visualfsharp? It should not implicitly add things when you explicitly set the flag, right?

0x53A · 2017-07-16T09:54:06Z

Will do

forki · 2017-07-16T16:41:13Z

can you please send a second PR that only sets the properties in the targets file?

0x53A · 2017-07-16T19:09:18Z

I don't think that is a good idea.

When you do dotnet new and paket convert, the resulting project will be broken (and still compiling, so the user doesn't notice it).

I would say let's wait for a response on that issue, maybe there is a compilerflag to disable the magic core reference?

0x53A · 2017-07-16T22:12:24Z

Great, locally I have the same three PathTooLongException failures, but I also have one that may be more interesting:

Edit:

Cause:

The specified SDK version [2.0.0-alpha-005165] from global.json [C:\source\Paket\global.json] not found; install specified SDK version
Did you mean to run dotnet SDK commands? Please install dotnet SDK from:
http://go.microsoft.com/fwlink/?LinkID=798306&clcid=0x409

It is picking up the global.json from the paket root folder. Probably a good idea to hardcode the cli version.

matthid · 2017-07-16T22:26:35Z

It feels like this test needs to be reworked. It's not working on travis either, see here

0x53A · 2017-07-17T19:28:13Z

I need to test if it actually works (probably doesn't, I know myself =) ), and a few unit tests would also be nice, but from my side this is mostly finished.

As it stands, it adds FSharp.Core on convert-from-nuget and warns (I downgraded it from an error) on install if a v15 F# project does not reference FSharp.Core.

What do you think?

0x53A · 2017-08-03T18:10:35Z

Manual test:

dotnet new lib -lang F#
paket convert-from-nuget
Check that both paket.dependencies and paket.references contain FSharp.Core ✔
manually remove FSharp.Core from paket.references
Check that a warning was printed ✔

CI fails with __ PathTooLongException__ :\

forki · 2017-08-17T13:50:27Z

what is the status?

0x53A · 2017-08-19T18:16:46Z

Ready from my side.

CI errors seem unrelated, but please verify.

I've rebased it on master, which wiped the CI history, so here is a link to the previous CI result: https://ci.appveyor.com/project/SteffenForkmann/paket/build/0.0.1.9005

0x53A · 2017-08-20T12:50:51Z

AppVeyor: PathTooLongException
Travis: each stage passed at least once ;-)

matthid · 2017-08-20T13:09:12Z

Maybe we can add long-path support for the test suite on appveyor (via App.Config). We don't really care about too long paths there. As the appveyor is green on master and our only check right now I think we need it to be green here as well. Or we wait for #2584?

0x53A · 2017-08-20T13:13:29Z

Kay, let me shorten the scenario names a bit ...

warn when a sdk f# project does not contain a reference to fsharp.core

0x53A · 2017-08-20T16:07:07Z

@matthid green

matthid

Looks good to me.

matthid · 2017-08-20T16:27:40Z

src/Paket.Core/PackageManagement/NugetConvert.fs

@@ -227,6 +227,22 @@ let createPackageRequirement sources (packageName, versionRange, restrictions) d
       TransitivePrereleases = false
       Graph = Set.empty }

+let private isFSharpproject (projectFileName:string) =


isFSharpProject ?

0x53A · 2017-08-20T17:02:24Z

If I understand it correctly, Pack does a Restore, which goes to github, and doesn't seem to be cached.

matthid · 2017-08-20T19:26:20Z

Would be interesting to see WHAT is not cached. We had some problems with the bootstrapper in the past (where dotnet was calling the bootstrapper in magic mode).
Maybe we need to set some verbose flags:

PAKET_BOOTSTRAPPER_TRACE=true allows to set the bootstrapper into verbose mode.
you maybe can temporarily add "-v" to the paket targets file.

This is when this error is actually reproducible.

0x53A · 2017-08-20T19:35:17Z

no idea - I think this may not actually be an issue with paket, because the build in my fork also failed with the same error. So it seems the AppVeyor Datacenter as a whole hit the limit.

Anyway, now it is green again.

forki · 2017-08-21T09:36:03Z

thanks!

0x53A mentioned this pull request Jul 16, 2017

[Sdk 2] Compiler does not fail if FSharp.Core is not referenced dotnet/fsharp#3340

Closed

0x53A force-pushed the paket-and-dotnet-and-fs branch from e1281d7 to cd4d874 Compare August 9, 2017 17:41

0x53A changed the title ~~[wip] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core~~ [Readz] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core Aug 13, 2017

0x53A changed the title ~~[Readz] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core~~ [Ready] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core Aug 13, 2017

0x53A force-pushed the paket-and-dotnet-and-fs branch from b656db7 to bb317e7 Compare August 19, 2017 18:16

0x53A added 2 commits August 20, 2017 16:52

dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core

a97aad3

warn when a sdk f# project does not contain a reference to fsharp.core

shorten scenario names

4a7f53f

0x53A force-pushed the paket-and-dotnet-and-fs branch from 07c44f8 to 4a7f53f Compare August 20, 2017 14:54

0x53A changed the title ~~[Ready] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core~~ [Really Ready] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core Aug 20, 2017

matthid approved these changes Aug 20, 2017

View reviewed changes

Codereview: casing isFSharpproject->isFSharpProject

28576a5

0x53A closed this Aug 20, 2017

0x53A reopened this Aug 20, 2017

forki merged commit 28576a5 into fsprojects:master Aug 21, 2017

0x53A deleted the paket-and-dotnet-and-fs branch August 21, 2017 12:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Really Ready] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core #2528

[Really Ready] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core #2528

0x53A commented Jul 15, 2017

forki commented Jul 16, 2017

0x53A commented Jul 16, 2017

forki commented Jul 16, 2017

0x53A commented Jul 16, 2017

forki commented Jul 16, 2017

0x53A commented Jul 16, 2017

forki commented Jul 16, 2017

0x53A commented Jul 16, 2017

0x53A commented Jul 16, 2017 •

edited

Loading

matthid commented Jul 16, 2017

0x53A commented Jul 17, 2017

0x53A commented Aug 3, 2017 •

edited

Loading

forki commented Aug 17, 2017

0x53A commented Aug 19, 2017

0x53A commented Aug 20, 2017

matthid commented Aug 20, 2017

0x53A commented Aug 20, 2017

0x53A commented Aug 20, 2017

matthid left a comment

matthid Aug 20, 2017

0x53A commented Aug 20, 2017

matthid commented Aug 20, 2017

0x53A commented Aug 20, 2017 •

edited

Loading

forki commented Aug 21, 2017

[Really Ready] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core #2528

[Really Ready] dotnet sdk: disable implicitly adding system.valuetuple and fsharp.core #2528

Conversation

0x53A commented Jul 15, 2017

forki commented Jul 16, 2017

0x53A commented Jul 16, 2017

forki commented Jul 16, 2017

0x53A commented Jul 16, 2017

forki commented Jul 16, 2017

0x53A commented Jul 16, 2017

forki commented Jul 16, 2017

0x53A commented Jul 16, 2017

0x53A commented Jul 16, 2017 • edited Loading

matthid commented Jul 16, 2017

0x53A commented Jul 17, 2017

0x53A commented Aug 3, 2017 • edited Loading

forki commented Aug 17, 2017

0x53A commented Aug 19, 2017

0x53A commented Aug 20, 2017

matthid commented Aug 20, 2017

0x53A commented Aug 20, 2017

0x53A commented Aug 20, 2017

matthid left a comment

Choose a reason for hiding this comment

matthid Aug 20, 2017

Choose a reason for hiding this comment

0x53A commented Aug 20, 2017

matthid commented Aug 20, 2017

0x53A commented Aug 20, 2017 • edited Loading

forki commented Aug 21, 2017

0x53A commented Jul 16, 2017 •

edited

Loading

0x53A commented Aug 3, 2017 •

edited

Loading

0x53A commented Aug 20, 2017 •

edited

Loading