Refactor nuget #2410
Merged
Refactor nuget #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
reviewed
Jun 10, 2017
src/Paket.Core/Dependencies/Nuget.fs
Outdated
|
|
||
| let request = HttpWebRequest.Create(downloadUri) :?> HttpWebRequest | ||
| #if NETSTANDARD1_6 | ||
| // Note: this code is not working on regular non-dotnetcore |
There was a problem hiding this comment.
We have this same block in a few places, would it make sense to pull out an http abstraction that handles doing this the right way in a single place?
There was a problem hiding this comment.
Yes. It's really unfortunate. I have the same code in FAKE as well :/
Problem is this is already a lightweight abstraction (see Paket.Utils) it's just that at this particular place they have subtle different behavior. I noted somewhere I'd would be better to use the new HttpClient everywhere but I didn't want to change everything at the time....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically everything was in the NuGetV2 module.
Now the following is separated:
This PR builds on top of #2362 (will be easier to review once I got #2362 green and merged it)