make the bootstrapper search harder for the paket.dependencies file #2384
Conversation
|
👍 on the On the trace I don't see the double parsing (Might have read too fast) and having a way to early-log is good. |
| @@ -23,9 +23,13 @@ static void Main(string[] args) | |||
| Console.CancelKeyPress += CancelKeyPressed; | |||
|
|
|||
| var fileProxy = new FileSystemProxy(); | |||
| var optionsBeforeDependenciesFile = ArgumentParser.ParseArgumentsAndConfigurations(args, ConfigurationManager.AppSettings, | |||
| Environment.GetEnvironmentVariables(), fileProxy, Enumerable.Empty<string>()); | |||
| ConsoleImpl.Verbosity = optionsBeforeDependenciesFile.Verbosity; | |||
There was a problem hiding this comment.
@vbfox This is what I mean, we call ParseArgumentsAndConfigurations again below with an additional argument (which is Empty here).
I'm pretty sure we could refactor this somehow, but I couldn't come up with a nice way without changing basically everything.
There was a problem hiding this comment.
Maybe the check for the environment variable should be done directly at that level without calling the ArgumentParser.
Accepting that the only way to verbose-log the early/configuration part of the bootstrapper is the environment variable.
like paket is doing it.
@vbfox please review. In particular I don't like how we now parse the command line twice in order to set the verbosity (such that we can trace on errors when finding the dependencies file). A better idea is welcome.
I guess I still need to add a test for this (I'm first trying to get the FAKE build green again).