Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging of conflicts during resolution #2379

Closed
wants to merge 0 commits into from
Closed

Add logging of conflicts during resolution #2379

wants to merge 0 commits into from

Conversation

stendavid
Copy link

If there are conflicts, it is difficult to see why Paket discards certain versions of a package. This patch adds some logging of conflicts during resolution to help trouble-shooting of dependencies.

Output looks like this (from the test "shold solve strange graph")
Resolving packages for group Main:

  • P7 11.10.10.3
  • P3 5.5.7.9
  • P1 10.11.11
    Incompatible dependency: P7 <= 4.2.11.10 conflicts with resolved version 11.10.10.3
    Can't take package P1 10.11.11: incompatible dependencies
    Failed to satisfy P1 <= 10.11.11 (from P3 5.5.7.9)
  • P3 1.1.3
    Failed to satisfy P8 <= 0.2.8 (from P3 1.1.3)
    Failed to satisfy P3 (from )
  • P7 10.3.5.7
    Incompatible dependency: P7 <= 4.2.11.10 conflicts with resolved version 10.3.5.7
    Can't take package P1 10.11.11: incompatible dependencies
    Failed to satisfy P1 <= 10.11.11 (from P3 5.5.7.9)
    Failed to satisfy P3 (from )
  • P7 4.2.11.10

For real projects with dependency problems there may be a lot of extra output, so maybe it should log only if --verbose. On the other hand, in that case it's really useful info...

@matthid
Copy link
Member

matthid commented May 29, 2017

Wow thanks wanted to add something similar. So I'll happily review this as soon as I can (probably in afew days)

@matthid matthid self-requested a review May 29, 2017 21:30
@matthid matthid self-assigned this May 29, 2017
@matthid matthid closed this Jun 1, 2017
@matthid
Copy link
Member

matthid commented Jun 1, 2017

Oh this didn't work as intended :/ I rebased your branch to trigger the CI again and GitHub doesn't seem to be able to handle that... Can you open the PR again please :)

@matthid
Copy link
Member

matthid commented Jun 1, 2017

Sorry @zzDavid

@matthid
Copy link
Member

matthid commented Jun 1, 2017

Oh now I know what I did wrong. I apparently pushed the wrong branch to your repro (which is allowed as the PR was open). But now the PR was closed by GitHub and I cannot fix it. But as you don't have the changes on your fork anymore I pushed them here: https://github.com/fsprojects/Paket/tree/zzdavid-master
I will open a PR (such that it is visible and reviewable). But I'd close that in favor of your PR if you find the time.
Sorry for the mess and confusion... Until we have a proper PR: #2379

@matthid matthid mentioned this pull request Jun 2, 2017
@stendavid
Copy link
Author

Right :) I'll fix my branch.

Also, I found out that logging without --verbose is not a good idea, at least not everything. The test "#1174 Should find Ninject error" really explodes with 60 000 log lines. (And it's still difficult to say why packages are rejected...)

@matthid
Copy link
Member

matthid commented Jun 2, 2017

@zzDavid We already merged and released that for testing already ;)
Will let you know when I tacke that again and have any feedback (or change the feature).

Yeah we currently have the problem that verbose is not really usable... But we need to improve on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants