[WIP] Fix rotating app.config entries when generating redirects #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please add a comment that making it strict is important!? |
gimpf
force-pushed
the
rotating-binding-redirects
branch
from
dca1b1c to
3d0d8c5
Compare
|
of course ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An older commit termed "cleanup" seems to have inadvertently broken app.config binding redirects; they work, but on every paket install the order of the redirects is rotated, that is, the first one is moved to the last one (or the other way round).
This makes diffs more verbose than necessary, so I patched that out.
Tests still missing, but is it otherwise OK?