Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One of the file writes was missing a Directory.Create() #2080

Merged
merged 2 commits into from
Dec 15, 2016
Merged

One of the file writes was missing a Directory.Create() #2080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c569751
Don't ToLower the entire path, just the filename
jamesjrg Dec 15, 2016
b957295
Always Directory.Create() immediately before File.WriteAllText
jamesjrg Dec 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Paket.Core/ScriptGeneration.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ module ScriptGeneration =
pieces
|> String.concat ("\n")


scriptFile.Directory.Create()
File.WriteAllText(scriptFile.FullName, text)

let writeCSharpScript scriptFile input =
Expand Down Expand Up @@ -316,7 +318,6 @@ module ScriptGeneration =
match scriptGenerator scriptInfo with
| DoNotGenerate -> knownIncludeScripts
| Generate pieces ->
scriptFile.Directory.Create()
writeScript scriptFile pieces
knownIncludeScripts |> Map.add package.Name scriptFile

Expand Down Expand Up @@ -360,7 +361,8 @@ module ScriptGeneration =

let getGroupFile group =
let folder = getScriptFolder includeScriptsRootFolder framework group
FileInfo(Path.Combine(folder.FullName, sprintf "include.%s.group.%s" (group.GetCompareString()) extension).ToLowerInvariant())
let fileName = (sprintf "include.%s.group.%s" (group.GetCompareString()) extension).ToLowerInvariant()
FileInfo(Path.Combine(folder.FullName, fileName))

generateGroupScript dependenciesFile getGroupFile scriptWriter filterFrameworkLibs filterNuget framework

Expand Down