Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Install-Paket.ps1 to prevent embedding .exe in git. #1969

Closed
wants to merge 2 commits into from

Conversation

jschneidereit
Copy link

This checks the github api for the latest release and appropriately
downloads the paket bootstrapper. An optional parameter -AddToPath can
be used to add the paket directory to $env:Path for CI boxes.

The intent is to allow those who have *.exe in their .gitignore to more
easily use paket on Windows.

Jim Schneidereit added 2 commits October 18, 2016 17:44
This checks the github api for the latest release and appropriately
downloads the paket bootstrapper. An optional parameter -AddToPath can
be used to add the paket directory to $env:Path for CI boxes.

The intent is to allow those who have *.exe in their .gitignore to more
easily use paket on Windows.
@forki
Copy link
Member

forki commented Oct 19, 2016

I recommend to use the bootstrapper.

*.exe in git can easily worked around for that file. The bottstrapper as different fallback mechanisms like downloading from nuget when github is down. This will keep your builds much more green,

@matthid
Copy link
Member

matthid commented Oct 19, 2016

Tbh nobody likes PowerShell because it is not really xplat (no matter what they say about it being open source now, because it is just not installed on unix boxes).
Bash is more xplat because it is part of git which itself is part of visual studio (which most have installed)

@jschneidereit
Copy link
Author

@forki The intention was not to replace bootstrapper, just to provide an additional option for those who don't wish to embed binaries in their source control.

@forki
Copy link
Member

forki commented Oct 19, 2016

Still can't understand that strange requirement. We created the small
bootstrapper in order to keep size small and it doesn't change that often.
It's just not a real issue.

BTW did you see #1961 - it's
taking the whole thing to the next level.

Am 19.10.2016 20:03 schrieb "Jim Schneidereit" [email protected]:

@forki https://github.com/forki The intention was not to replace
bootstrapper, just to provide an additional option for those who don't wish
to embed binaries in their source control.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1969 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNE36mbByLv_kKbKeO5TEZ5JOMs8Bks5q1ltlgaJpZM4KaU8p
.

@jschneidereit
Copy link
Author

I think it's common enough of a scenario not to include binaries in source that I felt it was useful to give this option on Windows via PowerShell. I'm happy to close the PR if you think the bootstrapping model is the way to go.

@forki
Copy link
Member

forki commented Oct 20, 2016

Yes I think for a general recommendation the bootstrapper is the way to go. It's a much safer choice.

While I admire your effort to create a powershell bootstrapper and I am happy that you are willing to share it, I'm thinking this is not the way to go. Tbh that don't commit exe rule should not be considered as a 100% dogma. That just makes no sense and your life will be harder than it should be. Try to understand where the rule is coming from and why it is there. Try to understand what exceptions to that rule are useful.
Hint: often it's just that someone heard rumors that git is bad with binary files. Which is basically wrong.

@matthid
Copy link
Member

matthid commented Oct 21, 2016

I agree with @forki. On the other side if there would be a good way to do the same without a binary and X-Plat I would prefer it... Suggestions are welcome. So thanks for sharing your work. In fact there might even come the time when Powershell is installed by default on the large distributions... (I still hope god saves us from this ;) )

@jschneidereit
Copy link
Author

Sounds good, thanks for taking a look! (I hope god brings us PowerShell on all large distros 😆)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants