-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Install-Paket.ps1 to prevent embedding .exe in git. #1969
Conversation
This checks the github api for the latest release and appropriately downloads the paket bootstrapper. An optional parameter -AddToPath can be used to add the paket directory to $env:Path for CI boxes. The intent is to allow those who have *.exe in their .gitignore to more easily use paket on Windows.
I recommend to use the bootstrapper. *.exe in git can easily worked around for that file. The bottstrapper as different fallback mechanisms like downloading from nuget when github is down. This will keep your builds much more green, |
Tbh nobody likes PowerShell because it is not really xplat (no matter what they say about it being open source now, because it is just not installed on unix boxes). |
@forki The intention was not to replace bootstrapper, just to provide an additional option for those who don't wish to embed binaries in their source control. |
Still can't understand that strange requirement. We created the small BTW did you see #1961 - it's Am 19.10.2016 20:03 schrieb "Jim Schneidereit" [email protected]:
|
I think it's common enough of a scenario not to include binaries in source that I felt it was useful to give this option on Windows via PowerShell. I'm happy to close the PR if you think the bootstrapping model is the way to go. |
Yes I think for a general recommendation the bootstrapper is the way to go. It's a much safer choice. While I admire your effort to create a powershell bootstrapper and I am happy that you are willing to share it, I'm thinking this is not the way to go. Tbh that don't commit exe rule should not be considered as a 100% dogma. That just makes no sense and your life will be harder than it should be. Try to understand where the rule is coming from and why it is there. Try to understand what exceptions to that rule are useful. |
I agree with @forki. On the other side if there would be a |
Sounds good, thanks for taking a look! (I hope god brings us PowerShell on all large distros 😆) |
This checks the github api for the latest release and appropriately
downloads the paket bootstrapper. An optional parameter
-AddToPath
canbe used to add the paket directory to
$env:Path
for CI boxes.The intent is to allow those who have *.exe in their .gitignore to more
easily use paket on Windows.