-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[utils] trying to fix #1873 #1874
Conversation
It doesn't cover the Token in config, because that's how I interpreted the |
Mhm. maybe we don't need the token in the config. But we definetly need some docs for this. |
Ok I will write something... |
thanks for adding this! |
/cc @Thorium |
I always have problems with this one. And the reason is that I have multiple files from same repository like this:
Now what happens it that when I call paket update, it asks for the latest comment id for all in parallel multiple requests. (How could it know that it is the same for all!) And when the first response comes, it caches it, but before the response it has already made the other requests. GitHub thinks that this is flood (like it is) and blocks me. So there is no any kind of singleton in this: it makes the requests in parallel and no locks. Responses are saved to a ConcurrentDictionary which is not used as locking (remember maybe the concurrency-memoize-getOrAdd what I have been talking about). And the reason that it can't lock is that it's async operation to fetch. I don't want to reference the whole huge repository of DefinitelyTyped. |
@Thorium does the new feature solve it for you? |
I think the API keys are not the actual problem. |
ok that it could be smatter when asking for the same repo is another issue. But API key still helps right? |
implements #1873