Bootstrapper: fixed partial download #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2016 19:06
Commit by Allon Guralnek <[email protected]> On branch: refs/heads/Bootstrapper_FixPartialDownload
Commit by Allon Guralnek <[email protected]> On branch: refs/heads/Bootstrapper_FixPartialDownload
|
cool thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, when downloading using the three-parameter
DownloadFilemethod (which was only used by theGitHubDownloadStrategy), it only downloaded a partial file. The simpler two-parameter overload (used byNugetDownloadStrategyTests) always downloaded a full file. It seems thestream.CopyTo()used in the three-parameter overload doesn't work well. I removed the problematic overload (which wasn't needed anyway, the simpler one is better). Now Paket always downloads files correctly for me.