Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local file - npkg in path version #1843

Merged
merged 6 commits into from
Aug 3, 2016
Merged

Local file - npkg in path version #1843

merged 6 commits into from
Aug 3, 2016

Conversation

theimowski
Copy link
Member

@theimowski theimowski commented Aug 2, 2016 •
edited
Loading

TODO:

  • docs

References #1803

@theimowski theimowski changed the title WIP: Local file - npkg in path version Local file - npkg in path version Aug 3, 2016
@theimowski
Copy link
Member Author

theimowski commented Aug 3, 2016 •
edited
Loading

I think it's ready to be merged

@theimowski theimowski mentioned this pull request Aug 3, 2016
Closed
@gertjvr
Copy link

gertjvr commented Aug 3, 2016

Is #1838 trying to achieve the same thing?

@gertjvr
Copy link

gertjvr commented Aug 3, 2016

Eager to try this out, thanks again for implementing this

@theimowski
Copy link
Member Author

Lol haven't seen #1838 before and yeah i guess it serves the same purpose

@theimowski theimowski mentioned this pull request Aug 3, 2016
Merged
@forki forki merged commit 18062fe into fsprojects:master Aug 3, 2016
@theimowski theimowski deleted the local_file_version branch August 3, 2016 09:26
@theimowski
Copy link
Member Author

@forki weren't there any merge conflicts? I saw you merged #1838 before this one

@forki
Copy link
Member

forki commented Aug 3, 2016

I merged with --sours to get @creib into history but applied your PR

@theimowski
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theimowski @gertjvr @forki