Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing transitive dependencies from dependencies list #1547

Conversation

pms1969
Copy link
Contributor

@pms1969 pms1969 commented Mar 24, 2016

brings the dependency list in line with exactly what nuget produces (as far as I can tell).

@forki
Copy link
Member

forki commented Mar 24, 2016

Do we really want that? Is it needed?

@forki
Copy link
Member

forki commented Mar 24, 2016

(I mean probably want that - but what are we breaking currrently?)

@pms1969
Copy link
Contributor Author

pms1969 commented Mar 24, 2016

I guess it's more of a completeness thing than anything else. it declutters the output, and makes the dependency list that is generated by paket the same as nuget.

in a project of any size, (and I have a few at work), the depency list is relatively large. a good chunk of these dependencies are transitive. it leads to larger lock files I guess, and I need to justify the difference to the people I work under ;-)

@forki
Copy link
Member

forki commented Mar 24, 2016

ok will look into it

@forki forki merged commit 4353cfa into fsprojects:master Mar 24, 2016
forki added a commit that referenced this pull request Mar 24, 2016
@forki
Copy link
Member

forki commented Mar 24, 2016

Could you please review b014e55 and 11a4308? Thanks

@pms1969
Copy link
Contributor Author

pms1969 commented Mar 24, 2016

all looks good. just ran master against my solution here, and it worked as expected.

@forki
Copy link
Member

forki commented Mar 24, 2016

Do we influence the packaged dlls with it? I mean for packages that don't use dependencies but bundle their stuff we still need to package all deps. Otherwise that would create a bug right?

@pms1969
Copy link
Contributor Author

pms1969 commented Mar 24, 2016

that code just has an impact on the dependencies list, not on the packaged dlls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants