pdb's no longer being packaged in the non symbols package

[pms1969]

No description provided.

[forki]

Why that change?

[pms1969]

#1394

basically, if the pdb's are in the non-symbols package, VS won't download the symbols package for debugging.

[pms1969]

as far as I can tell, the Travis build was already borking on that test.

[forki]

So now we put the pdbs in the normal package, but not into the symbols
package?
On Jan 18, 2016 8:47 AM, "Paul Saunders" [email protected] wrote:

#1394 #1394

basically, if the pdb's are in the non-symbols package, VS won't download
the symbols package for debugging.

—
Reply to this email directly or view it on GitHub
#1403 (comment).

[pms1969]

Other way around.

[forki]

But not everyone is using symbols packages. What about the other case?
On Jan 18, 2016 8:51 AM, "Paul Saunders" [email protected] wrote:

Other way around.

—
Reply to this email directly or view it on GitHub
#1403 (comment).

[pms1969]

depends if you want strict nuget replication in that area or not. Nuget doesn't package them in the non-symbols regardless.

Should only require a small tweak to fix for when there is no symbols requested. Depends on what you'd like to do?

[forki]

I think we should still put the pdbs in the normal package when we don't
create a symbols package. That's what nuget does, right?
On Jan 18, 2016 9:05 AM, "Paul Saunders" [email protected] wrote:

depends if you want strict nuget replication in that area or not. Nuget
doesn't package them in the non-symbols regardless.

Should only require a small tweak to fix for when there is no symbols
requested. Depends on what you'd like to do?

—
Reply to this email directly or view it on GitHub
#1403 (comment).

[pms1969]

No it doesn't, tho i'll confirm that.

In the case that you want to add them, you can still add it as a file dependency and it won't be removed. (I've just confirmed that that is true of that build)

[pms1969]

Confirmed. Nuget does not include pdb's regardless of whether symbols have been requested or not.

[forki]

Ok. Let's remove them then. But how about a template file property that
automatically adds them? Should be a good alternative for people so they
don't have to use explicit file references
On Jan 18, 2016 9:17 AM, "Paul Saunders" [email protected] wrote:

Confirmed. Nuget does not include pdb's regardless of whether symbols have
been requested or not.

—
Reply to this email directly or view it on GitHub
#1403 (comment).

[pms1969]

not a bad idea? so for project files only?
property: include-pdbs
default: false
??

meaningless for file templates.

[forki]

yes that would be awesome

[pms1969]

do you want that as part of this pull request or another?

[forki]

please add it to this one.

[pms1969]

done

[pms1969]

travis failing on the same tests. It has an ignore on it, so not sure why it gets run.