ConfigFile: password encryption does not work on specific machine con… #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figurations. This is the minimal fix to make password encryption work in our environment. seealso issue: fsprojects#1346
|
mhm this doesn't work on travis!? |
|
ah ok. awesome. no solution works on all configurations. We could do a simple probing - handle exception and try in local machine mode if user mode fails. what you think? |
|
sounds good. whatever works to make it work for more people is fine |
… user encryption scope and local machine if attempt fails)
|
works now |
| try | ||
| ProtectedData.Protect(Encoding.UTF8.GetBytes password, salt, DataProtectionScope.CurrentUser) | ||
| with | :? CryptographicException as e -> | ||
| traceWarnfn "could not protect password: %s\n for current user" e.Message |
There was a problem hiding this comment.
i think a verbosefn might be enough here
forki
added a commit
that referenced
this pull request
Jan 5, 2016
ConfigFile: password encryption does not work on specific machine con…
|
thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #1346
Note that i did not change DataProtectionScopes for decryption. This is is the minimal change i know which works (i think decrpytion ignores this).
The docs do not say anything about this: e.g. https://msdn.microsoft.com/en-us/library/2fh8203k(v=vs.110).aspx