Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for specifying per-template versions in paket pack #1314

Merged
merged 3 commits into from
Dec 19, 2015

Conversation

eiriktsarpalis
Copy link
Member

This PR attempts to address the problem described in #1265. It incorporates the possibility to supply specific version numbers on a per-template basis:

paket pack version 1.1.2 specific-version Experimental.Lib 0.0.1-alpha specific-version Another.Experimental.Lib 1.0-beta

This has the behaviour of overriding the version number in specified template id's and ensures that this is reflected in wherever CURRENTVERSION is being replaced. When running the above command, the following file:

id Another.Experimental.Lib
dependencies
     Core.Lib CURRENTVERSION
     Experimental.Lib CURRENTVERSION

should generate a package equivalent to the template below:

id Another.Experimental.Lib
version 1.0-beta
dependencies
     Core.Lib 1.1.2
     Experimental.Lib 0.0.1-alpha

Please review. I will be posting a corresponding PR to the FAKE paket components to reflect this change.

@inosik
Copy link
Contributor

inosik commented Dec 18, 2015

I like this 👍

I'm currently working on something, which would help us to keep the dependencies node out of paket.template, so we don't need to repeat what we might have in paket.references.

Look here for more.

forki added a commit that referenced this pull request Dec 19, 2015
Implement support for specifying per-template versions in paket pack
@forki forki merged commit a4bf87c into fsprojects:master Dec 19, 2015
@forki
Copy link
Member

forki commented Dec 19, 2015

thx. and sorry that I didn't fix that other issue yet.

@eiriktsarpalis
Copy link
Member Author

Thanks! I've updated my code to use the latest update. Here's what it looks like: mbraceproject/MBrace.Core@807eb2f#diff-6074983490330a0aac1bd23c958232d7R105

@eiriktsarpalis eiriktsarpalis deleted the custom-versions branch December 19, 2015 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants