-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to cache proxy #1153
try to cache proxy #1153
Conversation
//cc @vasily-kirichenko could you please take a look? |
Looks like an ordinary thread safe memoization. Maybe it is worth to extract |
the question is more: do you think it's enough to cache proxy per HTTP host? |
No idea. |
fair enough ;-) |
This reverts commit 8968df9.
I released this as 2.16.0-alpha001. @alexeyzimarev, @alistair please check if it improves things @vasily-kirichenko could you please verify that we don't break you thanks everbody. |
@dnauck you are also behind proxy, right? |
I am at home now and have no proxy. Will be able to check tomorrow if I would reach my machine at work, I will be at another office for three days. |
So I have just updated to the latest, cleaned cache and packages directory and run the following https://gist.github.com/alistair/65cba5d92556e6f0457c Time taken has dropped from 7 minutes to 1. |
@forki no .. not with my dev machine, cannot test Most commercial proxy solutions have virus checking, so the first download and unzip of nuget packages for virus check could take a long time. If the package is too large or contains to many files it could also fail. |
Conflicts: RELEASE_NOTES.md src/Paket.Bootstrapper/Properties/AssemblyInfo.cs src/Paket.Core/AssemblyInfo.fs src/Paket.PowerShell/AssemblyInfo.fs src/Paket/AssemblyInfo.fs
Conflicts: RELEASE_NOTES.md src/Paket.Bootstrapper/Properties/AssemblyInfo.cs src/Paket.Core/AssemblyInfo.fs src/Paket.PowerShell/AssemblyInfo.fs src/Paket/AssemblyInfo.fs
Conflicts: RELEASE_NOTES.md src/Paket.Bootstrapper/Properties/AssemblyInfo.cs src/Paket.Core/AssemblyInfo.fs src/Paket.PowerShell/AssemblyInfo.fs src/Paket/AssemblyInfo.fs
I tested with 2.16.0 and it works splendidly 👍 46 seconds instead of seven minutes. |
Awesome. Thanks for all the help here. |
Tested |
It's only faster for a handful of people where the proxy detection was
|
for a couple of users it seems to be very very slow to calc the proxy. see https://gitter.im/fsprojects/Paket discussion with @alexeyzimarev