Fixes lock file restrictions parsing #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let optionsString = | ||
| if parts.Length < 2 then "" else | ||
| if parts.[1] <> "" && parts.[1].Contains(":") |> not then | ||
| ("framework: " + parts.[1]) // TODO: This is for backwards-compat and should be removed later |
There was a problem hiding this comment.
Should this be removed by now?
There was a problem hiding this comment.
Nope. Please remove the comment. I guess we better keep it forever
mrinaldi
force-pushed
the
parse_lockfile_restrictions
branch
from
49f9296 to
a2977e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the parsing of restrictions of transitive dependencies in lock file.
Using the
paket.dependenciesbelowIt generates a different
paket.lockwhen I runpaket installtwice.The same happens if I run a
paket updatefollowed by apaket install.