Support for authentication and complex hosts. #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
forki
added a commit
that referenced
this pull request
Sep 7, 2015
Support for authentication and complex hosts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P.R adds support for authentication to HTTP dependencies and also prevents HTTP dependencies failing with an invalid path exception is the authority part of the URL is a IP or a DNS + PORT.
Couple of things to note. I have added an additional parameter to the http spec that allows you to specify the sourceName. This is the key that is used to look up the credentials in the auth store. And example of the full spec is now
This will use the
MySourceas the auth key, and the folder name should become10.235.123.16_19/MySource.Also the documentation has been updated to reflect this change.