Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagerly create app.config files and add to all projects. #1044

Merged
merged 3 commits into from
Sep 8, 2015

Conversation

isaacabraham
Copy link
Contributor

Can someone review this, as it's quite an invasive change in terms of files that can be amended / created as a result of this. Whenever the binding redirects code now gets called, Paket will: -

  1. Locate all paket.references files.
  2. Create an very bare app.config file if one doesn't already exist.
  3. Go through the standard app.config binding redirects code, applying BRs to both existing configuration files and those that were just created.
  4. Add any new app.config files to any cs / fs / vbproj that it finds alongside it.

@isaacabraham
Copy link
Contributor Author

Hmmm. System.IO.Path behaves differently between Travis and AppVeyor?

@isaacabraham
Copy link
Contributor Author

OK, so Path.GetDirectoryName etc. use different formats between windows and unix. But on Windows it will eagerly turn e.g. "C:/foo/bar/" into "C:\foo\bar".

@forki forki merged commit c1da150 into fsprojects:master Sep 8, 2015
@forki
Copy link
Member

forki commented Sep 8, 2015

cool. let's see how this works in practice ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants