-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework github strategy to use a more direct method in the common case… #1022
Conversation
… of just getting the latest version
TODO: pagination on the prerelease-case |
I think there should be no pagination on the prerelease case. If there is no prerelease on the first page then there is no active prerelease. |
ah, and the prerelease logic is really 'latest including prerelease', so we're really just grabbing the first of the 'all releases' page then? that makes that logic simpler as well. |
Yes we only want the super latest and greatest (and broken) version.
|
Alright, all better. |
thanks! |
rework github strategy to use a more direct method in the common case…
sorry. I messed up. The new bootstrapper doesn't work on prerelease case. It should always get the latest version, but github shows the last released version on top (even if that's older than the latest) |
sounds like we should always get the latest version via the new mechanism, then, and then use that version to compare against if the user requests a prerelease? so /releases/latest => 1.99.0 ? |
… of just getting the latest version