-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paket adding empty references #992
Comments
things like? |
GitHub escaped the XML tag, updated comment above. Sorry! |
yes. @TIHan fixed our support for the portable profiles and android + iOS. So Paket is expected to update your csproj and fsproj files. Anything broken? |
Nothing is broken but seeing like 20 of those in a row not actually adding a reference so not expecting to see them. Is it supposed to remove them? |
the empty Whens take care of not referencing the lib when you change to that target framework. |
Event at the root level? Here is the full extract, does it look correct to you? If so, sorry for wasting your time!
|
nope that looks strange indeed. will take this one as a test and try to fix it ;-) do you have paket.dependencies and paket.lock for me? |
Thanks mate! Can I ping them over in an email please? This solution is part of our core business logic with a lot of internal packages names. |
yes sforkmann @ gmail |
Done |
I fixed something, but I'm not sure if that works for you. could you please try to run |
I actually manually fixed this but reverted the project referenced above back to the weird version and ran an install with 1.31.0 and they were not removed. I just went back though the checkin history when this was committed and pulled the before and after csproj files. It looks like the paket.references files was deleted (as there were no longer any external references to this project) and a paket.template files was included but that already existed in the folder but not referenced by the project (shouldn't be an issue). Hopefully that helps! Before:
After:
|
yes that helps. I can now reproduce that the empty whens get removed when I have a paket.references file but not if no paket.references is found. I think this is OK and we should not touch project files if they don't have a references file. Please add an empty paket.references file. |
Hi,
I am seeing things like this being added to my csproj with version 1.29.1
Cheers,
Chris
The text was updated successfully, but these errors were encountered: