Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the bootstrapper/paket.targets #790

Closed
dnauck opened this issue Apr 21, 2015 · 13 comments
Closed

Updating the bootstrapper/paket.targets #790

dnauck opened this issue Apr 21, 2015 · 13 comments

Comments

@dnauck
Copy link
Contributor

dnauck commented Apr 21, 2015

Currently we don't have updates or update notifications for the bootstrapper.

We could either:

  1. check for the latest release when running the bootstrapper and display a notification when a new release is available
  2. check for the latest release when running the bootstrapper and auto-update its executable
    1. by Shadow Copying Assemblies
    2. move the locked bootstrapper.exe, download a new bootstrapper and cleanup on next run
  3. let paket.exe handle the bootstrapper like a dependency and display it on paket outdated or update it on paket update, etc.

It should also update the paket.targets file when required.

Current disadvantages:

  • bootstrapper is updated on every paket.exe release even if there was no changes
@matthid
Copy link
Member

matthid commented Apr 21, 2015

Seriously wondering why this wasn't suggested earlier.
I'm voting for option "3" which seems to be the easiest to implement.
IMHO we should not complicate the bootstrapper if we don't really need to. For example "1" could be integrated in the paket startup code instead or as suggested in 'paket outdated' (which I would prefer).

@Stift
Copy link
Contributor

Stift commented Apr 21, 2015

I have thought about it earlier and thought about paket.bootstrapper.exe --self
I came to that point when github had problems some time ago and we implemented an alternative nuget download. The only problem I had so far with that is that in the nuget package is no paket.bootstraper.

@Stift
Copy link
Contributor

Stift commented Apr 21, 2015

BTW you can copy it over the current bootstrapper.exe to self update

@forki
Copy link
Member

forki commented Apr 23, 2015

so we need a Paket.Boostrapper package?

@dnauck
Copy link
Contributor Author

dnauck commented Apr 23, 2015

@Stift what about the paket.targets file?

How do we know when to run the update command? every time? or is paket.exe outdated running this?

@Stift
Copy link
Contributor

Stift commented Apr 23, 2015

@forki in case we want a self update via nuget we could need one

@Stift
Copy link
Contributor

Stift commented Apr 23, 2015

@dnauck have not considered yet the paket.target file, but could be done easily. Do we consider the paket.target as unchangeable and overwrite it without asking? I'm just asking because users could change it and are not aware of a change.
My proposal is currently supporting ´paket.bootstrapper.exe --self´. I chose that because when we had outages of github it was difficult to even get paket.exe. Should we just show with ´paket outdated´ that the bootstrapper is outdated and show a suggestion.

@forki
Copy link
Member

forki commented Apr 24, 2015

@Stift
Copy link
Contributor

Stift commented Apr 24, 2015

Thank you @forki for the package I have included this now.

@Stift
Copy link
Contributor

Stift commented Jun 3, 2015

This issue is still open, because the request of @dnauck for updating the paket.targets file is still unresolved.
I had some time to think about this and thought about that we should maybe let the bootstrapper stick with downloading the latest paket.exe as functionality.
The paket.targets is originally downloaded by the paket.exe when you do paket.exe autorestore on. IMO we should bring the functionality somewhere near here.
My suggestion would be sth like paket autorestore update, to either only update the file or turn the feature off and on. Any other ideas?

@dnauck
Copy link
Contributor Author

dnauck commented Jun 4, 2015

Currently the bootstrapper also updates itself via --self on every paket release. Also there is no warning if its outdated, etc.

@Stift
Copy link
Contributor

Stift commented Jun 5, 2015

That would be easily doable. We just display an info when updating that just checks the latest version an displays it.
There is only one problem, that for the github download we cannot detect whether there is a real change @sforki. So each paket release we see immediately an outdated message.

@forki
Copy link
Member

forki commented Oct 31, 2016

Closing old issue.

@forki forki closed this as completed Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants