Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket pack seems to miss some properties #665

Closed
forki opened this issue Feb 27, 2015 · 7 comments · Fixed by #666
Closed

Paket pack seems to miss some properties #665

forki opened this issue Feb 27, 2015 · 7 comments · Fixed by #666
Labels

Comments

@forki
Copy link
Member

forki commented Feb 27, 2015

type project
owners
    Steffen Forkmann, Max Malook, Tomasz Heimowski
authors 
    Steffen Forkmann, Max Malook, Tomasz Heimowski
projectUrl
    http://github.com/fsprojects/Chessie
iconUrl
    https://raw.githubusercontent.com/fsprojects/Chessie/master/docs/files/img/logo.png
licenseUrl
    http://github.com/fsprojects/Chessie/blob/master/LICENSE.txt
requireLicenseAcceptance
    false
copyright
    Copyright 2015
tags
    rop, fsharp, F#
summary
    Railway-oriented programming for .NET
description
    Railway-oriented programming for .NET

in https://github.com/fsprojects/Chessie/blob/master/src/Chessie/paket.template results in:

image

/cc @mavnn I think we found our package issue.

@forki forki added the bug label Feb 27, 2015
@forki
Copy link
Member Author

forki commented Feb 27, 2015

the generated nuspec is:

<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<package xmlns="http://schemas.microsoft.com/packaging/2011/10/nuspec.xsd">
  <metadata>
    <id>Chessie</id>
    <version>0.0.2</version>
    <authors>Steffen Forkmann, Max Malook, Tomasz Heimowski</authors>
    <owners>Steffen Forkmann, Max Malook, Tomasz Heimowski</owners>
    <description>Railway-oriented programming for .NET</description>
    <summary>Railway-oriented programming for .NET</summary>
    <releaseNotes>XML-docs added</releaseNotes>
    <copyright>Copyright 2015</copyright>
    <tags>rop, fsharp, F#</tags>
  </metadata>
</package>

@mavnn
Copy link
Contributor

mavnn commented Feb 27, 2015

It's not the causes of the crashes - the compulsory fields have come through OK (only id, version, authors and description are required).

That said, it is still a bug. It's very odd that you've got some of the optional fields but not all of them.

I'll look into it, it might be something I'm not testing in the new parser.

@mavnn
Copy link
Contributor

mavnn commented Feb 27, 2015

Tags should be space separated according to the spec, by the way - although nuget.org appears to just strip the commas anyway.

@forki
Copy link
Member Author

forki commented Feb 27, 2015

Tags should be space separated according to the spec, by the way - although nuget.org appears to just strip the commas anyway.

we should do the same. Because I will never learn that ;-)

@mavnn
Copy link
Contributor

mavnn commented Feb 27, 2015

Break the spec whilst creating 📦 s?! Heresy!

I'll add a Trim along with the embarrassing bug fix.

@forki
Copy link
Member Author

forki commented Feb 27, 2015

looks much better! thx.
But the title is still missing. Can we do some default value for this?

@forki forki reopened this Feb 27, 2015
@mavnn
Copy link
Contributor

mavnn commented Feb 27, 2015

No, I don't think so. It's supposed to be optional.

On 27 February 2015 at 11:01, Steffen Forkmann [email protected]
wrote:

looks much better! thx.
But the title is still missing. Can we do some default value for this?


Reply to this email directly or view it on GitHub
#665 (comment).

@forki forki closed this as completed Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants