Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket fails with invalid local sources #372

Closed
tpluscode opened this issue Nov 19, 2014 · 7 comments
Closed

Paket fails with invalid local sources #372

tpluscode opened this issue Nov 19, 2014 · 7 comments

Comments

@tpluscode
Copy link
Contributor

One my machine I had some local package sources defined in NuGet. Now when I used paket in a new project, when fetching versions for X it would fail saying that part of path wan not found. It actually happened for two different paths. One indeed doesn't exist and the other contains spaces. I guess that invalid sources should be skipped, maybe with a warning and paths with spaces should be handled correctly.

@forki
Copy link
Member

forki commented Nov 19, 2014

Can you please give a small repro of the paket.dependencies?

@tpluscode
Copy link
Contributor Author

Now that I try to reproduce it I get even weirder behaviour. I created a new solution and a paket.dependencies file with some bogus local path. When I do paket add nuget X that local source is removed from the file.

@tpluscode
Copy link
Contributor Author

And about spaces. I just realized that the path was actually imported incomplete. Without anything after the first space

@forki
Copy link
Member

forki commented Nov 19, 2014

Please give concrete repro steps. I will fix it asap

@tpluscode
Copy link
Contributor Author

Invalid source:

  1. Clone https://github.com/tpluscode/paket-dependencies/
  2. .paket/paket.exe add nuget Newtonsoft.Json
  3. Could not find a part of the path "c:\no\such\folder".

Disappearing source:

  1. Clone https://github.com/tpluscode/paket-dependencies/
  2. Remove NodaTime from paket.dependencies so that only sources lines remain
  3. .paket/paket.exe add nuget Newtonsoft.Json
  4. Package is added but the local source is gone

@forki
Copy link
Member

forki commented Nov 19, 2014

Invlid source:

image

I'd argue this is correct. We should not ignore this.

Regarding the disappearing source: that's fixed in 0.15.2

@tpluscode
Copy link
Contributor Author

Maybe you're right. I won't insist. Thanks for the other fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants