Resolution by file order instead of alphabetical order

[troykershaw]

Description

When Paket has no way to determine package weight, it defaults to alphabetical order. I would like it to resolve by the order the packages are written in the paket.dependencies file.

Is there a way to do this?

If not, would you welcome a PR that implements it (using a paket.dependencies flag)?

Repro steps

I have a paket.dependencies file that requires two packages Xylophone (not real) and Kafunk (real). The file does not lock a version on either.

nuget Xylophone
nuget Kafunk

The Kafunk library has versions 0.1.8 and 0.1.9.

The Xylophone library has two release (1.0 and 2.0) that depend on Kafunk like so:
v2 : nuget Kafunk =0.1.8
v1 : nuget Kafunk >=0.0.1

Expected behavior

What I would like is to resolve by file order. Xylophone is first in the file, so resolve to 2.0, then resolve Kafunk, which would give 0.1.8

Actual behavior

Paket will try to resolve dependencies in alphabetical order. It starts with Kafunk, gets the latest (0.1.9), then looks for the version of Xylophone that supports 0.1.9. This resolves to Xylophone version 1.0. Like so:

Kafunk (0.1.9)
Xylophone (1.0)

Known workarounds

Lock the version of Kafunk to the version used in the preferred Xylophone.

nuget Xylophone
nuget Kafunk =0.1.8

The problem with this as a solution is that users of Xylophone and Kafunk need to know that not only is there a resolution issue, but they need to manually update the Kafunk version to match the latest Xylophone version.

[forki]

After thinking about it: I think I would accept a pr which changes this behavior Am 14.11.2017 23:37 schrieb "Troy Kershaw" <[email protected]>:

…

Description When Paket has no way to determine package weight, it defaults to alphabetical order. I would like it to resolve by the order the packages are written in the paket.dependencies file. Is there a way to do this? If not, would you welcome a PR that implements it (using a paket.dependencies flag)? Repro steps I have a paket.dependencies file that requires two packages Xylophone (not real) and Kafunk (real). The file does not lock a version on either. nuget Xylophone nuget Kafunk The Kafunk library has versions 0.1.8 and 0.1.9. The Xylophone library has two release (1.0 and 2.0) that depend on Kafunk like so: v2 : nuget Kafunk =0.1.8 v1 : nuget Kafunk >=0.0.1 Expected behavior What I would like is to resolve by file order. Xylophone is first in the file, so resolve to 2.0, then resolve Kafunk, which would give 0.1.8 Actual behavior Paket will try to resolve dependencies in alphabetical order. It starts with Kafunk, gets the latest (0.1.9), then looks for the version of Xylophone that supports 0.1.9. This resolves to Xylophone version 1.0. Like so: Kafunk (0.1.9) Xylophone (1.0) Known workarounds Lock the version of Kafunk to the version used in the preferred Xylophone. nuget Xylophone nuget Kafunk =0.1.8 The problem with this as a solution is that users of Xylophone and Kafunk need to know that not only is there a resolution issue, but they need to manually update the Kafunk version to match the latest Xylophone version. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2898>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNGETXfifw5IczRfKNmpgFLajXedoks5s2hYcgaJpZM4QeG2v> .

[troykershaw]

Thanks Steffen, I'll get a PR together and we can discuss from there.

[forki]

So what I think you would need to do: look at packagerequirement and add a new field Position. Then add to the CompareTo implementation. Fix all compiler issues. Done. Am 15.11.2017 14:15 schrieb "Troy Kershaw" <[email protected]>:

…

Thanks Steffen, I'll get a PR together and we can discuss from there. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2898 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNCCl9-G1A2JatzuQF7b83UUkg-XBks5s2uPjgaJpZM4QeG2v> .

[troykershaw]

Thanks, that's a great help. Would you like this to replace the comparison by name, or should I feature flag it?

[forki]

The alphabetical was only a tie breaker anyway. I like to be able to break it manually Am 15.11.2017 14:54 schrieb "Troy Kershaw" <[email protected]>: Thanks, that's a great help. Would you like this to replace the comparison by name, or should I feature flag it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2898 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNIkIW6ryFuJcF6vxAaYF_nj6zMnvks5s2u0IgaJpZM4QeG2v> .

[forki]

I built that as part of conflict resolution fixes. Release under way

[troykershaw]

Thanks Steffen, your change was much cleaner than mine was turning out to be :)
I enjoyed going through the code and seeing how it all works under the hood.