Paket convert-from-nuget adds paket.dependencies incorrectly to the solution file

[alexeyzimarev]

Description

When using Paket 5.6.6, after running conversion from nuget on a solution with one project, the reference to the paket.dependencies is added in a way that the solution file fails to load.

Repro steps

Create a solution with one project.
Create a .paket directory and put Paket 5.6.6 there.
Run .paket\paket convert-from-nuget
Run .paket\paket auto-restore on

Try loading the solution in VS or Rider. Solution is not loaded.

Expected behavior

Solution should load and there should be a .paket solution folder added, with paket.dependencies file link in the solution folder.

The solution file section should look like:

Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".paket", ".paket", "{3AC709DB-BDCA-4965-9004-52FC24A2425B}"
	ProjectSection(SolutionItems) = preProject
		..\paket.dependencies = ..\paket.dependencies
	EndProjectSection
EndProject

Actual behavior

The solution file is broken. It looks like this:

Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".paket", ".paket", "{3AC709DB-BDCA-4965-9004-52FC24A2425B}"
		..\paket.dependencies = ..\paket.dependencies
	ProjectSection(SolutionItems) = preProject
	EndProjectSection
EndProject

Known workarounds

Edit the solution file and move the line with paket.dependencies file inside the ProjectSection

[forki]

I bet it's related to #2484 /cc @fsoikin

[fsoikin]

Indeed. I'll send another pull reqfefe.

[fsoikin]

I wonder though, @forki: after my fix, why did all tests pass?

[forki]

because this is probably untested ...