Forcing lowercase with tolower(Id) yields poor Proget performance during resolution #2466

Christoba · 2017-06-26T23:14:39Z

Description

When resolving packages on a Proget Nuget feed with 150k package versions, the use of tolower(Id) in tryGetAllVersionsFromNugetODataWithFilter breaks performance optimizations around "Id eq 'package'" in Proget. This forces full enumeration of packages in the feed, which is orders of magnitude slower.

See related question posted to http://inedo.com/support/questions/6810

Repro steps

Please provide the steps required to reproduce the problem

paket.dependencies references a package with source as a Proget feed with 100s of thousands of package version
Issue a get using Id='', Version='' and compare performance to a paket update on the same package.

Expected behavior

Paket could provide syntax or a keyword override within paket.dependencies to disable case insensitivity handling like tolower()

forki · 2017-06-27T06:17:37Z

Mhm I am not sure why we even do that. The first request for the package name should actually return the correct casing. But maybe that's not the case in one of the other feeds.

Christoba · 2017-06-29T16:49:51Z

Is it possible that this could be changed? The behavior I've been seeing implies that the toLower is being used off the bat with nuget.

forki · 2017-06-29T17:38:28Z

I assume it is possible. But I can't remember if why we added it. Please send a pull request and we see what it breaks.

matthid · 2017-07-09T20:20:47Z

I don't think we don't think we propagate the casing of the first query, only the casing from the paket.dependencies file. But what we do is that we already try the faster url.

@Christoba can you check if casing correctly in paket.dependencies is a workaround?
Also a logfile would be helpful to see why paket has to fallback to the slower url.

I'm not sure where paket can find the proper casing, the only other call we do is getversions, so maybe we could get the info from there?

forki · 2017-07-11T08:25:06Z

@Christoba can you please retry with latest?

Christoba · 2017-07-11T19:42:18Z

We've seen a definite improvement (we're all using 5.6.6 right now) and resolution is down to seconds.

Casing is something that I aligned early on (shortly after the ticket was entered) and it didn't seem to have a direct benefit, but this was a couple of weeks back. Thanks for the update!

matthid · 2017-07-20T21:41:34Z

Ok I think we should probably add a warning when we use the fallback ToLower to tell the user he can improve performance by using proper casing in dependencies file.

forki · 2017-07-21T05:58:20Z

Instead of a warning we could look casing up in the lockfile. So only very first resolution would be slow. Or we could alternatively patch the deps file. Am 20.07.2017 23:41 schrieb "Matthias Dittrich" <[email protected]>:

…

Reopened #2466 <#2466>. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2466 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNNaJgpWYh62hF_2X_X8y3rnhzwNyks5sP8mPgaJpZM4OF9yu> .

matthid · 2017-07-21T06:34:02Z

Yes I agree, but warning is simpler to implement ;)
Patching lock or depsfile can introduce a bunch of new issues and needs a lot of testing. But yes it's the better option long term.

Long-term we could fixup casing directly while resolving, so warnings will disappear with next install or update (at least that was the thinking when I suggested the warning)

matthid · 2017-07-21T06:35:24Z

Or maybe we need to use a query/find API first to find the properly cased Id for each source, no idea.

rasmus · 2017-08-09T05:33:21Z

We are also seeing this with our ProGet server. And along with #1777 it makes Paket almost impossible to use at our organisation.

forki · 2017-08-09T05:47:15Z

@rasmus do you have correct casing in your dependencies file? I changed it to try the given casing first and only fallback to lower when nothing was found

rasmus · 2017-08-09T05:54:30Z

@forki So as a workaround we'll have to specify correct casing for all of our indirect dependencies?

forki · 2017-08-09T05:59:24Z

No indirect deps are probed with the casing from the nuspec definitions of the direct deps. So in most cases they should be correct.

rasmus · 2017-08-09T06:14:06Z

@forki So the problem is that some package in our chain of dependencies have listed owin instead of Owin?

forki · 2017-08-09T07:00:44Z

This or we have a bug somewhere. But paket should honor casing from deps file and nuspec files/ your proget api.

rasmus · 2017-08-09T07:46:36Z

@forki I tried added the line nuget Owin our paket.dependencies and did a .paket\paket.exe install -v. If understand you correctly this should make Paket request Owin and not use the tolower(Id). Owin has correct casing in the lock file as well for all references.

Paket version 5.84.0
found: C:\git\project\paket.dependencies
Parsing C:\git\project\paket.dependencies
Skipping resolver for group Main since it is already up-to-date
C:\git\project\paket.lock is already up-to-date
Installing into projects:
 - Creating model and downloading packages.

[CUT: too many packages]

Downloading Owin 1.0.0
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:00Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with Version instead of NormalizedVersion.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:03Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with NormalizedVersion as Version instead of Version.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:08Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
GetPackageDetails failed: System.Exception: Couldn't get package details for package Owin 1.0.0 on http://nuget-server/nuget/Default.
   at [email protected](String msg)
   at [email protected](Unit unitVar)
   at [email protected](AsyncParams`1 args)
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:12Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with Version instead of NormalizedVersion.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:17Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with NormalizedVersion as Version instead of Version.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:21Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
Something went wrong while downloading Owin 1.0.0
Message: Could not download Owin 1.0.0.
  ==> Trying again
Downloading Owin 1.0.0
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:24Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with Version instead of NormalizedVersion.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:29Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with NormalizedVersion as Version instead of Version.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:32Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
GetPackageDetails failed: System.Exception: Couldn't get package details for package Owin 1.0.0 on http://nuget-server/nuget/Default.
   at [email protected](String msg)
   at [email protected](Unit unitVar)
   at [email protected](AsyncParams`1 args)
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:35Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with Version instead of NormalizedVersion.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:37Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with NormalizedVersion as Version instead of Version.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:42Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
Something went wrong while downloading Owin 1.0.0
Message: Could not download Owin 1.0.0.
  ==> Last trial
Downloading Owin 1.0.0
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:46Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with Version instead of NormalizedVersion.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:49Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with NormalizedVersion as Version instead of Version.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:53Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
GetPackageDetails failed: System.Exception: Couldn't get package details for package Owin 1.0.0 on http://nuget-server/nuget/Default.
   at [email protected](String msg)
   at [email protected](Unit unitVar)
   at [email protected](AsyncParams`1 args)
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (NormalizedVersion eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:39:58Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with Version instead of NormalizedVersion.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:40:04Z</updated><link rel="self" title="Packages" href="Packages" /></feed>
No results, trying again with NormalizedVersion as Version instead of Version.
Starting request to 'http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0')'
Response from http://nuget-server/nuget/Default/Packages?$filter=(tolower(Id) eq 'owin') and (Version eq '1.0.0'):

<?xml version="1.0" encoding="utf-8"?><feed xml:base="http://nuget-server/nuget/Default/" xmlns:d="http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns="http://www.w3.org/2005/Atom"><title type="text">Packages</title><id>http://nuget-server/nuget/Default/Packages()/</id><updated>2017-08-09T07:40:07Z</updated><link rel="self" title="Packages" href="Packages" /></feed>

-> Could not download Owin 1.0.0.
   StackTrace:
        at [email protected](Exception _arg13)
        at [email protected](AsyncParams`1 args)
     --- End of stack trace from previous location where exception was thrown ---
        at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
        at Microsoft.FSharp.Control.AsyncBuilderImpl.commit[a](AsyncImplResult`1 res)
        at Microsoft.FSharp.Control.CancellationTokenOps.RunSynchronouslyInCurrentThread[a](CancellationToken token, FSharpAsync`1 computation)
        at Microsoft.FSharp.Control.CancellationTokenOps.RunSynchronously[a](CancellationToken token, FSharpAsync`1 computation, FSharpOption`1 timeout)
        at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken)
        at Microsoft.FSharp.Collections.Internal.IEnumerator.map@74.DoMoveNext(b& )
        at Microsoft.FSharp.Collections.Internal.IEnumerator.MapEnumerator`1.System-Collections-IEnumerator-MoveNext()
        at Microsoft.FSharp.Core.CompilerServices.RuntimeHelpers.takeOuter@274[T,TResult](ConcatEnumerator`2 x, Unit unitVar0)
        at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
        at Microsoft.FSharp.Collections.SeqModule.ToArray[T](IEnumerable`1 source)
        at Paket.InstallProcess.InstallIntoProjects[a](InstallerOptions options, Boolean forceTouch, DependenciesFile dependenciesFile, LockFile lockFile, FSharpList`1 projectsAndReferences, FSharpMap`2 updatedGroups)
        at Paket.UpdateProcess.SmartInstall(DependenciesFile dependenciesFile, UpdateMode updateMode, UpdaterOptions options)
        at <StartupCode$Paket-Core>[email protected](Unit unitVar0)
        at Paket.Utils.RunInLockedAccessMode[a](String rootFolder, FSharpFunc`2 action)
        at [email protected](ParseResults`1 results)
        at Paket.Program.processWithValidation[T](Boolean silent, FSharpFunc`2 validateF, FSharpFunc`2 commandF, ParseResults`1 result)
        at Paket.Program.main$cont@710(ParseResults`1 results, Boolean silent, Boolean fromBootstrapper, Unit unitVar)
        at Paket.Program.main()
-> Couldn't get package details for package Owin 1.0.0 on http://nuget-server/nuget/Default.

Performance:
 - Disk IO: 447 milliseconds
 - Average Request Time: 3 seconds
 - Number of Requests: 18
 - Runtime: 1 minute, 13 seconds

forki · 2017-08-09T07:50:50Z

Mmm. I think we need to invest this then. I'm currently very short on time since we got a baby. But maybe I find a minute.

rasmus · 2017-08-09T07:54:03Z

@forki Congratulations 😄 I understand difficulties of finding time to open source when having kids

forki · 2017-08-09T07:55:06Z

Investigate. Damn phone.

forki · 2017-08-09T10:00:33Z

ok found 5min. can you please retry with latest? It should at least try with correct casing now and the number that is given in the lock file. So if you manually change that to 1.0 then it should at least now work with ProGet.

rasmus · 2017-08-09T10:14:42Z

@forki tried it out, but the initial search URL looks like http://dev-nuget/nuget/Default/Packages?$filter=(Id eq 'nunit') and (NormalizedVersion eq '3.7.1'). Shouldn't that be NUnit (with a capital N and U)? It seems that it will always do a fallback as nunit != NUnit

forki · 2017-08-09T10:16:47Z

Oups. That's what you get for doing this in 5min. Can you please take a look at the very last commit. Then you can see the change and just remove the to lower in that url call and send a PR? Then I will released asap. Sorry. Am 09.08.2017 12:14 nachm. schrieb "Rasmus Mikkelsen" < [email protected]>:

…

@forki <https://github.com/forki> tried it out, but the initial search URL looks like http://dev-nuget/nuget/Default/Packages?$filter=(Id eq 'nunit') and (NormalizedVersion eq '3.7.1'). Shouldn't that be NUnit (with a capital N and U)? It seems that it will always do a fallback as nunit != NUnit — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2466 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNLMSkJT5HRrr5ubW6T1i0nQrObBSks5sWYaSgaJpZM4OF9yu> .

rasmus · 2017-08-09T10:17:45Z

@forki no problem, it happens 😉

forki · 2017-08-09T12:56:24Z

Ok fixed it. Hopefully. Can you please retry

rasmus · 2017-08-09T13:27:00Z

@forki Very nice, that fixed the performance problems. Thanks.

matthid · 2017-08-17T16:10:56Z

Can you all please retry with 5.86.0-alpha002. Otherwise we might break you on next release.

matthid added the needs-repro label Jul 9, 2017

forki closed this as completed in 610b21d Jul 11, 2017

matthid added needs-test-case and removed needs-repro labels Jul 20, 2017

matthid reopened this Jul 20, 2017

rasmus mentioned this issue Aug 9, 2017

Question about Normalized Version Numbers and third party Nuget server (ProGet) #1777

Open

forki closed this as completed in b6a23e2 Aug 9, 2017

forki added a commit that referenced this issue Aug 9, 2017

Faster lookup in Proget - fixes #2466

b2116af

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forcing lowercase with tolower(Id) yields poor Proget performance during resolution #2466

Forcing lowercase with tolower(Id) yields poor Proget performance during resolution #2466

Christoba commented Jun 26, 2017

forki commented Jun 27, 2017

Christoba commented Jun 29, 2017

forki commented Jun 29, 2017

matthid commented Jul 9, 2017

forki commented Jul 11, 2017

Christoba commented Jul 11, 2017

matthid commented Jul 20, 2017

forki commented Jul 21, 2017 via email

matthid commented Jul 21, 2017

matthid commented Jul 21, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017 •

edited

Loading

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017 via email

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

matthid commented Aug 17, 2017

Forcing lowercase with tolower(Id) yields poor Proget performance during resolution #2466

Forcing lowercase with tolower(Id) yields poor Proget performance during resolution #2466

Comments

Christoba commented Jun 26, 2017

Description

Repro steps

Expected behavior

forki commented Jun 27, 2017

Christoba commented Jun 29, 2017

forki commented Jun 29, 2017

matthid commented Jul 9, 2017

forki commented Jul 11, 2017

Christoba commented Jul 11, 2017

matthid commented Jul 20, 2017

forki commented Jul 21, 2017 via email

matthid commented Jul 21, 2017

matthid commented Jul 21, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017 • edited Loading

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017 via email

rasmus commented Aug 9, 2017

forki commented Aug 9, 2017

rasmus commented Aug 9, 2017

matthid commented Aug 17, 2017

rasmus commented Aug 9, 2017 •

edited

Loading