[Bootstrapper] Should not request Github while cache is valid

[matthid]

Description

The following behavior was noticed in a netcore project when restoring stuff with the bootstrapper in magic mode:

EXEC : The remote server returned an error : (429) Too Many Requests. (Github - cached (temporarily ignore updates)) [C:\PROJ\FAKE\src\app\Fake.DotNet.Testing.NUnit\Fake.DotNet.Testing.NUnit.fsproj]
C:\PROJ\FAKE\.paket\Paket.Restore.targets(17,5): error MSB3073: The command ""C:\PROJ\FAKE\.paket\paket.exe" restore --project "C:\PROJ\FAKE\src\app\Fake.DotNet.Testing.NUnit\Fake.DotNet.Testing.NUnit.fsproj" --target-framework netstandard1.6" exited with code -1. [C:\PROJ\FAKE\src\app\Fake.DotNet.Testing.NUnit\Fake.DotNet.Testing.NUnit.fsproj]
EXEC : The remote server returned an error : (429) Too Many Requests. (Github - cached (temporarily ignore updates)) [C:\PROJ\FAKE\src\app\Fake.DotNet.Testing.XUnit2\Fake.DotNet.Testing.XUnit2.fsproj]
C:\PROJ\FAKE\.paket\Paket.Restore.targets(17,5): error MSB3073: The command ""C:\PROJ\FAKE\.paket\paket.exe" restore --project "C:\PROJ\FAKE\src\app\Fake.DotNet.Testing.XUnit2\Fake.DotNet.Testing.XUnit2.fsproj" --target-framework netstandard1.6" exited with code -1. [C:\PROJ\FAKE\src\app\Fake.DotNet.Testing.XUnit2\Fake.DotNet.Testing.XUnit2.fsproj]
EXEC : The remote server returned an error : (429) Too Many Requests. (Github - cached (temporarily ignore updates)) [C:\PROJ\FAKE\src\app\Fake.IO.Zip\Fake.IO.Zip.fsproj]
C:\PROJ\FAKE\.paket\Paket.Restore.targets(17,5): error MSB3073: The command ""C:\PROJ\FAKE\.paket\paket.exe" restore --project "C:\PROJ\FAKE\src\app\Fake.IO.Zip\Fake.IO.Zip.fsproj" --target-framework netstandard1.6" exited with code -1. [C:\PROJ\FAKE\src\app\Fake.IO.Zip\Fake.IO.Zip.fsproj]

It seems like the bootstrapper still does a lot of requests when it shouldn't (that would improve speed in this scenario as well)

$ .paket/paket.bootstrapper.exe --max-file-age=720 --run --version
Checking Paket version (version 5.0.0-beta006 requested)...
Hash file of version 5.0.0-beta006 not found in cache.
Starting download from https://github.com/fsprojects/Paket/releases/download/5.0.0-beta006/paket-sha256.txt
Hash file of version 5.0.0-beta006 not found in cache.
Starting download from https://github.com/fsprojects/Paket/releases/download/5.0.0-beta006/paket-sha256.txt
No hash file of version 5.0.0-beta006 found in cache.
Copying version 5.0.0-beta006 from cache.
Done in 1.33 second(s).
Paket version 5.0.0-beta006

Known workarounds

Do not use magic mode

[forki]

/cc @vbfox

[vbfox]

It's a regression introduced by the hash file download, the cache for it never works (File is downloaded to a temporary location and never moved to the cache) it's not really linked to magic mode :)
Any use of the boostrapper would produce the same effect.

I'll fix it anyway 🦊

[matthid]

@vbfox Yeah I know (see my bug report which is without magic mode). It's just that this bug renders magic mode unusable with solutions containing a couple of netcore projects, because github is blocking quite fast...

Yeah I fix would be highly welcome because it is quite frustrating that I had to remove magic mode for now. (Sorry usually I'd just fix this myself but atm I'm trying to focus on a FAKE 5 release)